refactor: feature-based architecture with clean layer separation#169
Merged
Conversation
…tion" This reverts commit 443af99.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
hitori-mahjong | 359bbb9 | Jun 28 2026, 02:50 PM |
tknkaa
changed the title
- Add null check before destructuring randomHaiyama[0] in startNewGame and restartGame to prevent crash when no haiyama is available - Replace bare Error throws with GameError throughout service.ts so callers can discriminate status codes uniformly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Upgrade @biomejs/biome from 2.3.11 to 2.5.1 - Run biome migrate: update schema URL and replace deprecated linter.rules.recommended with preset - Switch check script from pnpx to local biome to avoid version skew - Add <title> to logo.svg to satisfy a11y/noSvgWithoutTitle Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-applies the clean architecture refactor that was previously reverted (#443af99).
lib/game-service.tsintofeatures/game/repository.ts(raw DB calls) andfeatures/game/service.ts(business logic)api.agari,api.games,api.ryukyoku,api.tedashi,api.tsumogiri) in favor of a single intent-dispatchedactioninroutes/play/_index.tsxapp/types/, auth tofeatures/auth/, DB toapp/db/, and nests route components/hooks undercomponents/andhooks/subdirectoriesagariandscorelogicpackage-lock.json) to pnpm (pnpm-lock.yaml)