Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Too many files changed for review (155 files, 100 file limit). Bypass the limit by tagging |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
6 issues found across 155 files
Confidence score: 3/5
apps/docs/vercel.jsonleaves the docs deployment’s Node.js runtime implicit whileapps/docs/package.jsonhas noenginesconstraint; Vercel could select an incompatible runtime despite the repository pin — configure the Vercel project or package to pin Node 24.11.1.apps/docs/package.jsonmakesopenapi:checkidentical tovalidate, removing the previous OpenAPI-specific check and allowing API spec regressions to go undetected — restore an explicit OpenAPI verification step.apps/docs/src/schemas/frontmatter.tsvalidatesnextbut not the widely usedprevnavigation metadata, so malformed previous links can pass schema checks; addprevto the schema and its validation.- The migrated docs contain six
type="success"callouts inapps/docs/docs/api/webhooks/events.mdx, an otherwise unsupported type, whileapps/docs/theme.cssreferences an undefined--blume-bordertoken for screenshots; verify the supported callout type and provide a defined border token before relying on the rendered styling.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/docs/theme.css">
<violation number="1" location="apps/docs/theme.css:8">
P3: `.doc-screenshot` uses `var(--blume-border)` for its border color, but that custom property is never defined in this file or anywhere else in the repository. If Blume's shipped theme does not export a token by that exact name, the `border` shorthand declaration becomes invalid at computed-value time and the screenshot border is silently dropped (falling back to no width). Confirm the token name against Blume's theme, or add a fallback value so the border survives a token mismatch.</violation>
</file>
<file name="apps/docs/package.json">
<violation number="1" location="apps/docs/package.json:12">
P3: The `openapi:check` script is now byte-identical to `validate` (`blume validate --strict`), so it no longer performs any OpenAPI-specific verification. Previously it ran `mint openapi-check https://api.usenotra.com/openapi.json` to compare the published spec against the live API. The documented workflow (README) still tells developers to run `openapi:sync` then `openapi:check` to review the snapshot, but `openapi:check` adds nothing beyond `validate` and won't signal a stale/mismatched OpenAPI snapshot. Either give `openapi:check` a real OpenAPI comparison or drop the duplicate script so it isn't misleading.</violation>
</file>
<file name="apps/docs/docs/api/webhooks/events.mdx">
<violation number="1" location="apps/docs/docs/api/webhooks/events.mdx:72">
P2: Every `<Callout>` in the migrated Blume docs uses only `note`, `tip`, `warning`, or `info`; `type="success"` appears nowhere else in the ~30 migrated .mdx files. These six newly added callouts are the only `success`-typed ones in the repo, suggesting Blume's Callout component does not define a `success` variant. If unsupported, they render with default styling or fail the strict `blume build`/`blume validate` checks. Convert these to a supported type (e.g. `info` or `note`), or verify `success` is a valid Blume Callout type before merging.</violation>
</file>
<file name="apps/docs/vercel.json">
<violation number="1" location="apps/docs/vercel.json:2">
P2: This vercel.json configures the docs deployment for Vercel but does not pin the Node.js runtime, and apps/docs/package.json has no `engines` field (the repo root pins node 24.11.1, but the Vercel project root is apps/docs and Vercel reads that package.json). The README explicitly requires **Node 24.x** for this deploy, so without a pin Vercel will build with its default Node version, which can break the `blume build` and the Bun-based install/build. Add `"engines": { "node": "24.11.1" }` to apps/docs/package.json (the repo root and Vercel settings already expect 24.x) so the docs build/deploy runs on a supported Node.</violation>
</file>
<file name="apps/docs/docs/automation/scheduled.mdx">
<violation number="1" location="apps/docs/docs/automation/scheduled.mdx:113">
P3: The `last_7_days` table row reads "**Default option.** The past 7 days (default)" — "Default option." and "(default)" both mark the default, so it is redundant. Drop one of them (e.g. "**Default option.** The past 7 days").</violation>
</file>
<file name="apps/docs/src/schemas/frontmatter.ts">
<violation number="1" location="apps/docs/src/schemas/frontmatter.ts:14">
P3: The `docolin` metadata in the source MDX files uses both `prev` and `next` navigation links (31 files each), but this schema only declares and validates `next`. Because the schema is `z.looseObject`, `prev` passes through unvalidated, so a typo'd or mis-typed `prev` (e.g. a wrong path) is silently accepted while the same error in `next` is caught. Add `prev: z.string().optional()` for parity with the documented metadata.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
|
||
| <Check>`ref` is the repository's default branch (`refs/heads/{default_branch}`)</Check> | ||
| <Check>The payload contains at least one commit</Check> | ||
| <Callout type="success">`ref` is the repository's default branch (`refs/heads/{default_branch}`)</Callout> |
There was a problem hiding this comment.
P2: Every <Callout> in the migrated Blume docs uses only note, tip, warning, or info; type="success" appears nowhere else in the ~30 migrated .mdx files. These six newly added callouts are the only success-typed ones in the repo, suggesting Blume's Callout component does not define a success variant. If unsupported, they render with default styling or fail the strict blume build/blume validate checks. Convert these to a supported type (e.g. info or note), or verify success is a valid Blume Callout type before merging.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/docs/docs/api/webhooks/events.mdx, line 72:
<comment>Every `<Callout>` in the migrated Blume docs uses only `note`, `tip`, `warning`, or `info`; `type="success"` appears nowhere else in the ~30 migrated .mdx files. These six newly added callouts are the only `success`-typed ones in the repo, suggesting Blume's Callout component does not define a `success` variant. If unsupported, they render with default styling or fail the strict `blume build`/`blume validate` checks. Convert these to a supported type (e.g. `info` or `note`), or verify `success` is a valid Blume Callout type before merging.</comment>
<file context>
@@ -59,20 +60,17 @@ Notra only accepts four GitHub event types on its webhook endpoint: `ping`, `pus
-<Check>`ref` is the repository's default branch (`refs/heads/{default_branch}`)</Check>
-<Check>The payload contains at least one commit</Check>
+<Callout type="success">`ref` is the repository's default branch (`refs/heads/{default_branch}`)</Callout>
+<Callout type="success">The payload contains at least one commit</Callout>
</file context>
| <Callout type="success">`ref` is the repository's default branch (`refs/heads/{default_branch}`)</Callout> | |
| <Callout type="info">`ref` is the repository's default branch (`refs/heads/{default_branch}`)</Callout> |
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "$schema": "https://openapi.vercel.sh/vercel.json", | |||
There was a problem hiding this comment.
P2: This vercel.json configures the docs deployment for Vercel but does not pin the Node.js runtime, and apps/docs/package.json has no engines field (the repo root pins node 24.11.1, but the Vercel project root is apps/docs and Vercel reads that package.json). The README explicitly requires Node 24.x for this deploy, so without a pin Vercel will build with its default Node version, which can break the blume build and the Bun-based install/build. Add "engines": { "node": "24.11.1" } to apps/docs/package.json (the repo root and Vercel settings already expect 24.x) so the docs build/deploy runs on a supported Node.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/docs/vercel.json, line 2:
<comment>This vercel.json configures the docs deployment for Vercel but does not pin the Node.js runtime, and apps/docs/package.json has no `engines` field (the repo root pins node 24.11.1, but the Vercel project root is apps/docs and Vercel reads that package.json). The README explicitly requires **Node 24.x** for this deploy, so without a pin Vercel will build with its default Node version, which can break the `blume build` and the Bun-based install/build. Add `"engines": { "node": "24.11.1" }` to apps/docs/package.json (the repo root and Vercel settings already expect 24.x) so the docs build/deploy runs on a supported Node.</comment>
<file context>
@@ -0,0 +1,6 @@
+{
+ "$schema": "https://openapi.vercel.sh/vercel.json",
+ "framework": null,
+ "buildCommand": "bun run build",
</file context>
| } | ||
|
|
||
| .doc-screenshot { | ||
| border: 1px solid var(--blume-border); |
There was a problem hiding this comment.
P3: .doc-screenshot uses var(--blume-border) for its border color, but that custom property is never defined in this file or anywhere else in the repository. If Blume's shipped theme does not export a token by that exact name, the border shorthand declaration becomes invalid at computed-value time and the screenshot border is silently dropped (falling back to no width). Confirm the token name against Blume's theme, or add a fallback value so the border survives a token mismatch.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/docs/theme.css, line 8:
<comment>`.doc-screenshot` uses `var(--blume-border)` for its border color, but that custom property is never defined in this file or anywhere else in the repository. If Blume's shipped theme does not export a token by that exact name, the `border` shorthand declaration becomes invalid at computed-value time and the screenshot border is silently dropped (falling back to no width). Confirm the token name against Blume's theme, or add a fallback value so the border survives a token mismatch.</comment>
<file context>
@@ -0,0 +1,36 @@
+}
+
+.doc-screenshot {
+ border: 1px solid var(--blume-border);
+ border-radius: 0.75rem;
+}
</file context>
| border: 1px solid var(--blume-border); | |
| border: 1px solid var(--blume-border, #e5e7eb); |
| "open": "blume dev --port 3005 --open", | ||
| "preview": "blume build --adapter node --strict && blume preview --port 3005", | ||
| "validate": "blume validate --strict", | ||
| "openapi:check": "blume validate --strict", |
There was a problem hiding this comment.
P3: The openapi:check script is now byte-identical to validate (blume validate --strict), so it no longer performs any OpenAPI-specific verification. Previously it ran mint openapi-check https://api.usenotra.com/openapi.json to compare the published spec against the live API. The documented workflow (README) still tells developers to run openapi:sync then openapi:check to review the snapshot, but openapi:check adds nothing beyond validate and won't signal a stale/mismatched OpenAPI snapshot. Either give openapi:check a real OpenAPI comparison or drop the duplicate script so it isn't misleading.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/docs/package.json, line 12:
<comment>The `openapi:check` script is now byte-identical to `validate` (`blume validate --strict`), so it no longer performs any OpenAPI-specific verification. Previously it ran `mint openapi-check https://api.usenotra.com/openapi.json` to compare the published spec against the live API. The documented workflow (README) still tells developers to run `openapi:sync` then `openapi:check` to review the snapshot, but `openapi:check` adds nothing beyond `validate` and won't signal a stale/mismatched OpenAPI snapshot. Either give `openapi:check` a real OpenAPI comparison or drop the duplicate script so it isn't misleading.</comment>
<file context>
@@ -1,12 +1,30 @@
+ "open": "blume dev --port 3005 --open",
+ "preview": "blume build --adapter node --strict && blume preview --port 3005",
+ "validate": "blume validate --strict",
+ "openapi:check": "blume validate --strict",
+ "openapi:sync": "bun run scripts/sync-openapi.ts"
+ },
</file context>
| | --- | --- | --- | | ||
| | `current_day` | `string` | From midnight UTC today until the run | | ||
| | `yesterday` | `string` | The previous calendar day (midnight to midnight UTC) | | ||
| | `last_7_days` | `string` | **Default option.** The past 7 days (default) | |
There was a problem hiding this comment.
P3: The last_7_days table row reads "Default option. The past 7 days (default)" — "Default option." and "(default)" both mark the default, so it is redundant. Drop one of them (e.g. "Default option. The past 7 days").
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/docs/docs/automation/scheduled.mdx, line 113:
<comment>The `last_7_days` table row reads "**Default option.** The past 7 days (default)" — "Default option." and "(default)" both mark the default, so it is redundant. Drop one of them (e.g. "**Default option.** The past 7 days").</comment>
<file context>
@@ -95,56 +96,44 @@ Schedules generate content at a fixed cadence from activity over a lookback wind
+| --- | --- | --- |
+| `current_day` | `string` | From midnight UTC today until the run |
+| `yesterday` | `string` | The previous calendar day (midnight to midnight UTC) |
+| `last_7_days` | `string` | **Default option.** The past 7 days (default) |
+| `last_14_days` | `string` | The past 14 days |
+| `last_30_days` | `string` | The past 30 days |
</file context>
| | `last_7_days` | `string` | **Default option.** The past 7 days (default) | | |
| | `last_7_days` | `string` | **Default option.** The past 7 days | |
| time_estimate: z.string(), | ||
| status: z.string(), | ||
| aliases: z.array(z.string()).optional(), | ||
| next: z.string().optional(), |
There was a problem hiding this comment.
P3: The docolin metadata in the source MDX files uses both prev and next navigation links (31 files each), but this schema only declares and validates next. Because the schema is z.looseObject, prev passes through unvalidated, so a typo'd or mis-typed prev (e.g. a wrong path) is silently accepted while the same error in next is caught. Add prev: z.string().optional() for parity with the documented metadata.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/docs/src/schemas/frontmatter.ts, line 14:
<comment>The `docolin` metadata in the source MDX files uses both `prev` and `next` navigation links (31 files each), but this schema only declares and validates `next`. Because the schema is `z.looseObject`, `prev` passes through unvalidated, so a typo'd or mis-typed `prev` (e.g. a wrong path) is silently accepted while the same error in `next` is caught. Add `prev: z.string().optional()` for parity with the documented metadata.</comment>
<file context>
@@ -0,0 +1,16 @@
+ time_estimate: z.string(),
+ status: z.string(),
+ aliases: z.array(z.string()).optional(),
+ next: z.string().optional(),
+ })
+ .optional();
</file context>
| next: z.string().optional(), | |
| next: z.string().optional(), | |
| prev: z.string().optional(), |
This branch was successfully deployed
1 participant
Description
Give a short summary of what this PR does and why it's needed.
Screenshot/Recording (if applicable)
Attach a screenshot or recording of the change. This is optional, but can help reviewers understand the change. You can use Cap to record a video.
Checklist
Summary by cubic
Migrates the product docs from Mintlify to Blume, refreshes GEO screenshots, and removes dashboard tests and skill eval fixtures. The API now allows CORS requests from
docs.usenotra.com(previously only Framer and local dev origins were allowed) so the new docs site can call it.Docs migration
mintCLI withblume.config.tsandblumescripts, and updatesREADME.md,AGENTS.md, andCONTRIBUTING.mdto reference Blume.Removed test infrastructure
testandsmoke:autonomypackage scripts.brand-logosandworkosskill eval fixtures along with the test ignore/exclude rules inknip.json,tsconfig.json,.gitignore, and.dockerignore.Written for commit d184215. Summary will update on new commits.