refactor(api): migrate brand identities to Effect programs

[janburzinski]

Description

Give a short summary of what this PR does and why it's needed.

Screenshot/Recording (if applicable)

Attach a screenshot or recording of the change. This is optional, but can help reviewers understand the change. You can use Cap to record a video.

Checklist

• I ran a self-review before opening this PR
• I ran formatting/linting/type checks locally
• I updated docs when behavior or setup changed
• I only added comments where the logic is not obvious
• I have used conventional commits for the PR title and commit messages
• I did not use AI to write the code in this PR or have disclosed that I did

  

---

Summary by cubic

Refactors brand identity API handlers into Effect programs with typed errors. Delete now returns 409 when the identity is referenced by projects or content briefs, instead of surfacing a raw foreign-key error.

Refactors

• Routes delegate to Effect programs in apps/api/src/programs/brand-identities.ts; database errors die and hit the central error handler.
• Adds typed domain errors and a shared respondToBrandIdentityFailure mapping for consistent error responses.
• The brand identity is only rolled back when the dashboard explicitly rejects workflow start (4xx or pre-flight configuration/auth failures). Transport timeouts and any post-acceptance Redis failure mark the job failed and return 503 without deleting.
• Selects GitHub app account type/login in the dashboard publish query so main typechecks.

^{Written for commit 14c3863. Summary will update on new commits.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

5 Skipped Deployments

Project	Deployment	Actions	Updated
notra	Skipped		Sep 12, 2026 9:59am UTC
notra-agent	Skipped		Sep 12, 2026 9:59am UTC
notra-onboarding-agent	Skipped		Sep 12, 2026 9:59am UTC
notra-ui	Skipped		Sep 12, 2026 9:59am UTC
notra-web	Skipped		Sep 12, 2026 9:59am UTC

[cubic-dev-ai]

1 issue found across 5 files

Confidence score: 3/5

• In apps/api/src/routes/brand-identities.ts, Redis job creation or update failures can now surface as an unhandled 500 while leaving the newly inserted brand identity behind, creating an inconsistent persisted state. Restore the documented 503 response and clean up the inserted identity on failure.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/api/src/routes/brand-identities.ts">

<violation number="1" location="apps/api/src/routes/brand-identities.ts:344">
P2: When Redis job creation or job update fails, this delegated path now produces an unhandled 500 and leaves the newly inserted brand identity behind instead of returning the documented 503 and cleaning it up. Keep job lifecycle failures in the queue-failure recovery path so the identity is removed and the caller receives `Failed to queue brand identity analysis`.</violation>
</file>

<sub>Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: When Redis job creation or job update fails, this delegated path now produces an unhandled 500 and leaves the newly inserted brand identity behind instead of returning the documented 503 and cleaning it up. Keep job lifecycle failures in the queue-failure recovery path so the identity is removed and the caller receives Failed to queue brand identity analysis.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/api/src/routes/brand-identities.ts, line 344:

<comment>When Redis job creation or job update fails, this delegated path now produces an unhandled 500 and leaves the newly inserted brand identity behind instead of returning the documented 503 and cleaning it up. Keep job lifecycle failures in the queue-failure recovery path so the identity is removed and the caller receives `Failed to queue brand identity analysis`.</comment>

<file context>
@@ -352,115 +340,25 @@ brandIdentitiesRoutes.openapi(createBrandIdentityRoute, async (c) => {
-      throw new Error("Failed to create brand identity");
-    }
+  const result = await runBrandIdentityProgram(
+    createBrandIdentity({
+      db: c.get("db"),
+      organizationId: orgId,
</file context>

[github-actions]

React Doctor found no new issues. 🎉

_{Reviewed by React Doctor for commit 14c3863.}

[cubic-dev-ai]

All reported issues were addressed across 5 files (changes from recent commits).

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

All reported issues were addressed across 2 files (changes from recent commits).

_{Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.}

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic</sub>

[CLAassistant]

All committers have signed the CLA.