feat: adds stage aware schema changes and module changes

[jpower432]

This PR builds on #8 by adds skills, commands, and agents for the first stage.

• Starts with a pre-PRD discovery phase
• The PRD is matured out of band
• Maturity is noted by status (Draft) and the appropriate review are completed per maturity level
• When --full is run the entire Review Council is run to evaluate readiness

[jflowers]

Review Council Report

Reviewers: 9 Divisor agents (Adversary, Architect, Curator, Guard, SRE, Testing, Envoy, Herald, Scribe)
Pre-flight: CI PASS (task test green on GitHub Actions)

Walkthrough

Directory	Files	Summary	Focus
.github/workflows/	2	CI workflow updates	ci-cd
.lola-eval/	12	New eval framework	standard
.taskfiles/	2	Task definitions + scripts	standard
module/agents/	6	PRD agent updates + 3 new discovery agents	documentation
module/commands/	2	Updated prd-review + new discovery command	documentation
module/skills/discovery/	2	New discovery skill + protocol	documentation
module/skills/prd-review/	2	Updated prd-review skill + protocol	documentation
examples/	3	Example PRDs updated	documentation
testdata/invalid/	7	New invalid test fixtures	test-quality
testdata/valid/	2	New valid test fixtures	test-quality
root	7	prd.cue, Taskfile, AGENTS.md, README.md, etc.	standard

---

HIGH — 7 findings

#	Finding	Reporters
H1	No migration guidance for breaking schema changes — 6+ field renames (persona→executor, workflow→journey, kpis→desired-outcomes, snake_case→kebab-case), removed concepts (personas, kpis), and Review→Ready status rename. Existing PRDs will silently fail cue vet with no explanation or migration path.	Envoy, Herald, Curator, SRE, Guard
H2	Missing CHANGELOG.md — Breaking schema changes, new discovery stage, two-tier review model, and NOTICE file addition all require changelog entries.	Curator, SRE, Herald
H3	No docs issues filed — Three distinct user-facing changes (discovery stage, schema migration, two-tier review) need documentation tracking issues.	Curator
H4	--full flag behavioral change undocumented — Default /prd-review silently changed from 5-agent council to Guard-only. Existing users get reduced review with no warning.	Guard
H5	Shell test runner lacks assertion specificity — task test validates pass/fail only, not which constraint caused rejection. A regression in one CUE constraint could be masked by another.	Testing
H6	Missing test fixtures for maturity gate and removed constructs — No invalid fixture for Ready AC requirement (ready-fr-missing-ac.yaml). No regression fixtures for removed personas on parent or workflow on phase.	Testing
H7	sed -i macOS incompatibility — provision.sh uses GNU sed -i syntax that fails on macOS (BSD sed requires backup extension). Developers on macOS cannot run task lola-eval:provision.	SRE, Adversary

MEDIUM — 10 findings

#	Finding	Reporters
M1	publish-cue.yml removes validation without replacement — Inline cue vet loop removed; publish workflow can now publish unvalidated schema to the CUE Central Registry.	Architect, SRE
M2	DRY violation: prd.cue duplicated in 2 eval starters — Byte-identical 129-line copies. Schema changes require updating 3 files.	Architect
M3	CUE version pinned in CI (v0.17.0) but not locally — Taskfile relies on whatever cue is on PATH. CUE 0.17 features may behave differently on older versions.	SRE
M4	provision.sh lacks cleanup on failure — Exits on error but leaves partially provisioned starters, producing misleading eval results on retry.	SRE
M5	Inconsistent task_version across eval cases — case-001 uses "2", case-002 uses "1". Undocumented version difference.	Architect, Testing
M6	No spec artifacts for 49-file PR — Constitution and AGENTS.md require spec workflow for non-trivial changes.	Guard
M7	Hardcoded example list in vet-examples — Three files explicitly listed; new examples won't be validated. Old publish-cue.yml used a glob.	SRE, Testing
M8	README prose density — Discovery and prd-review bullets pack 5+ concepts into single sentences. Agent roster table removed.	Scribe, Envoy, Herald
M9	Schema/agent enforcement split undocumented at schema level — desired-outcomes optional in CUE but Guard blocks at Ready/Approved. Intentional but not discoverable from the schema.	Architect
M10	test task uses set -u without set -e — Unexpected failures within the loop could be silently swallowed.	SRE

LOW — 12 findings

#	Finding
L1	Stale open_question reference in prd-curator.md (missed rename to open-questions)
L2	Missing EOF newline in ci.yml
L3	Trailing whitespace in discovery-gatherer.md and discovery-researcher.md
L4	Floating @main git dep for lola-eval (documented trade-off, dev-only)
L5	curl | sh suggestion in error message text (not executed)
L6	Task version floating 3.x in CI
L7	Heredoc tab indentation fragile in ensure-lola-eval.sh
L8	cue vet argument order inconsistency in discovery SKILL.md vs rest of repo
L9	Missing language identifiers on README code blocks
L10	Ready→Approved prohibition repeated 3x in same SKILL.md file
L11	Discovery command usage line ambiguous (<parent.yaml | "problem brief">)
L12	Sentence reflow in prd-guard.md after rename edit

Positive Observations

• SHA-pinned CI actions with version comments, least-privilege permissions, persist-credentials: false
• No secrets, credentials, or injection vectors in any changed file
• Clean eval isolation with synthetic .gitconfig and null'd GIT_CONFIG_GLOBAL
• NOTICE file properly follows Apache-2.0 Section 4(c)/(d)
• CUE schema inline comments are thorough — explain WHAT, HOW, and WHY
• Rename completeness is impressive across 49 files with only 1 miss
• Usage examples in README effectively demonstrate both modes
• Maturity-gated schema is a well-designed graduated enforcement model

Verdict

Reviewer	Verdict
Adversary	APPROVE
Architect	APPROVE
Curator	REQUEST CHANGES
Guard	REQUEST CHANGES
SRE	REQUEST CHANGES
Testing	REQUEST CHANGES
Envoy	NEEDS REVISION
Herald	NEEDS REVISION
Scribe	REQUEST CHANGES

Council Verdict: REQUEST CHANGES (7 of 9 reviewers)

Required Changes Before Merge

1. H1 + H2: Add CHANGELOG.md with migration mapping (old→new field names, removed fields, status enum change). Consider a sed recipe for bulk PRD migration.
2. H3: File 3 documentation issues (docs: label) for discovery stage, schema migration guide, and two-tier review behavior.
3. H4: Add prominent migration/breaking-change note about default /prd-review behavior change.
4. H5 + H6: Add assertion specificity to test runner (or document why pass/fail-only is acceptable) and add missing test fixtures (ready-fr-missing-ac.yaml, parent-has-personas.yaml, phase-has-workflow.yaml).
5. H7: Fix sed -i portability in provision.sh for macOS compatibility.
6. L1: Fix stale open_question → open-questions in prd-curator.md.
7. L2: Add trailing newline to ci.yml.

Recommended Improvements (Non-blocking)

• M1: Add task vet-examples to publish-cue.yml before publish step
• M2: Have provision.sh copy root prd.cue into starters (eliminate duplication)
• M7: Change vet-examples to use glob instead of hardcoded file list
• M8: Improve README prose density — break dense bullets into sub-lists
• M9: Add CUE comment on desired-outcomes?: explaining the schema/agent enforcement split

[jpower432]

Thanks for the review @jflowers. This PR needs a rebase so some of the request for changes may be from an already merged PR. I will address these and bootstrapping uf here in a new PR.