[WIP] Fix MIS implementation for environment map sampling - #5
Closed
umar-ahmed with Copilot wants to merge 1 commit into
Closed
[WIP] Fix MIS implementation for environment map sampling#5umar-ahmed with Copilot wants to merge 1 commit into
umar-ahmed with Copilot wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Issues Found:
Implementation Plan:
The changes will be focused on the
raytrace.wgslshader file. Key functions to modify:getEnvironmentMapUV()- increase binary search precision to 16 iterationsgetEnvironmentMapPDF()- add sin(θ) Jacobian correctiontrace()- implement MIS between BSDF and environment map samplingsampleEnvironmentMap()function for importance sampling💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.