Repository navigation
feat: add MaxRetries and MaxSleep options to customize retry behavior - #160
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Add MaxRetries and MaxSleep functional options to configure the retry attempts and maximum exponential backoff sleep duration when searching for leaked goroutines in Find, VerifyNone, and VerifyTestMain. Fixes uber-go#93
Author
|
Closing to align with previous maintainer direction on RetryPolicy abstraction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change introduces MaxRetries and MaxSleep functional options to allow callers to configure retry behavior when checking for goroutine leaks in Find, VerifyNone, and VerifyTestMain.
Previously, the maximum number of retry attempts (_defaultRetries = 20) and maximum sleep interval (100 * time.Millisecond) were hardcoded in buildOpts. Callers could not adjust these parameters for scenarios where goroutines require additional time to terminate, nor could they disable retries completely (e.g., via MaxRetries(0)) when testing code that must not leak goroutines even transiently.
Changes
Fixes #93