Repository navigation
feat: add a finalizer option to VerifyTestMain - #158
Open
sb123sb123 wants to merge 1 commit into
Open
sb123sb123 wants to merge 1 commit into
sb123sb123 wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
goleak.WithFinalizerforVerifyTestMain.The callback runs after
m.Run()and before goroutine leak detection, so package-level providers or other resources can be finalized before the final scan. Passing the option toFindis rejected, matching the existing option validation pattern.Fixes #133
Validation
go test ./... -run "^(TestVerifyTestMain|TestFind)$" -count=1go test ./... -count=1go vet ./...git diff --check-racerun was attempted but the Windows environment lacks a usable C compiler and headers (errno.h,stdlib.h, andwindows.h).AI disclosure
This change was prepared with assistance from an AI coding agent. The issue state, open PRs, repository policy files, diff, and test results were checked on the target branch.