Repository navigation
Add test coverage for elided frames with leading whitespace (#138) - #157
Merged
rabbbit merged 2 commits intoSep 15, 2026
Merged
Conversation
The fix in uber-go#138 handles elided frames with whitespace but lacked test coverage. This commit adds the missing test case.
The fix in uber-go#138 handles elided frames with whitespace but lacked test coverage. This commit adds the missing test case.
Contributor
Author
|
@abhinav have a look at this PR |
Collaborator
|
Thanks, @yamaankhan20. LGTM. |
abhinav
approved these changes
Sep 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 265 266 +1
=========================================
+ Hits 265 266 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds missing test coverage for the elided frames parsing fix implemented in #138 by @homme.
The fix in #138 handles goroutine stack traces with elided frames that have leading whitespace (e.g.,
" ...23 frames elided..."), but didn't include a test case. This PR adds that missing test.Changes
"elided frames with leading whitespaces"Test plan
GODEBUG=tracebackancestors=10 go test ./... -count=1go test ./internal/stack/... -run TestParseStack -vCredits
Related