Skip to content

Add test coverage for elided frames with leading whitespace (#138) - #157

Merged
rabbbit merged 2 commits into
uber-go:masterfrom
yamaankhan20:yamaan/fix-elided-frames-whitespace
Sep 15, 2026
Merged

rabbbit merged 2 commits into
uber-go:masterfrom
yamaankhan20:yamaan/fix-elided-frames-whitespace

Conversation

@yamaankhan20

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds missing test coverage for the elided frames parsing fix implemented in #138 by @homme.

The fix in #138 handles goroutine stack traces with elided frames that have leading whitespace (e.g., " ...23 frames elided..."), but didn't include a test case. This PR adds that missing test.

Changes

  • Added test case: "elided frames with leading whitespaces"

Test plan

  • All tests pass locally:
    • GODEBUG=tracebackancestors=10 go test ./... -count=1
    • go test ./internal/stack/... -run TestParseStack -v

Credits

Related

The fix in uber-go#138 handles elided frames with whitespace but lacked
test coverage. This commit adds the missing test case.
The fix in uber-go#138 handles elided frames with whitespace but lacked
test coverage. This commit adds the missing test case.
@CLAassistant

CLAassistant commented Sep 9, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@yamaankhan20

Copy link
Copy Markdown
Contributor Author

@abhinav have a look at this PR

@abhinav

abhinav commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Thanks, @yamaankhan20. LGTM.
CC @r-hang @JacobOaks

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (503ad8e) to head (512175b).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #157   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          265       266    +1     
=========================================
+ Hits           265       266    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rabbbit
rabbbit merged commit b656bfd into uber-go:master Sep 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants