Repository navigation
test: fix TestAll flakiness on Go 1.26 - #154
Merged
Merged
Conversation
TestAll sorted goroutines by ID and assumed the sorted order mapped to creation order (main, test goroutine, then the 5 workers). As of Go 1.26 goroutine IDs are no longer handed out in strict creation order, so a worker could sort ahead of the test goroutine and the positional assertions failed. Identify goroutines by their stack contents instead. Also join the worker goroutines before returning. They were previously leaked; under 'go test -race -count=N' a leftover worker from one iteration raced the next iteration's reassignment of the _allDone global. waitForDone stays argument-free (so it still exercises parsing of a no-arg frame) by signalling completion through a package-level WaitGroup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
=======================================
Coverage 99.24% 99.24%
=======================================
Files 5 5
Lines 264 264
=======================================
Hits 262 262
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
moisesvega
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestAll sorted goroutines by ID and assumed the sorted order mapped to creation order (main, test goroutine, then the 5 workers). As of Go 1.26 goroutine IDs are no longer handed out in strict creation order, so a worker could sort ahead of the test goroutine and the positional assertions failed. Identify goroutines by their stack contents instead.
Also join the worker goroutines before returning. They were previously leaked; under 'go test -race -count=N' a leftover worker from one iteration raced the next iteration's reassignment of the _allDone global. waitForDone stays argument-free (so it still exercises parsing of a no-arg frame) by signalling completion through a package-level WaitGroup.