Repository navigation
Conversation
Author
|
Context on prior work: #748 and #2641 address the same underlying inheritance/deduplication bug and are still unmerged. #2641 is essentially an updated/rebased version of #748. This PR takes a narrower approach: it changes deduplication only for If maintainers would prefer this work to be folded into #2641 instead, I’m happy to adjust. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a subclass adds a different validator to an inherited property, the parent's validators are incorrectly discarded because they share the
customValidationmetadata type. For example, adding@IsNotEmpty()in a subclass can silently remove the parent's@MinLength()check.Compare custom validation metadata by validator name, falling back to the constraint class for unnamed
@Validate()metadata. This preserves distinct inherited validators while retaining child overrides of the same validator and the existing handling of other metadata types.Fixes #2609.
Validation:
git diff --checkpass.PartialTypeconfirms inherited constraints are retained and optional fields remain optional.This change addresses inherited constraint loss; it does not change
PartialTypeoptionality or deduplication between multiple ancestor classes.