test(cardano): index the preprod blocks that broke native script decoding - #1359
Open
nicolasLuduena wants to merge 1 commit into
Open
nicolasLuduena wants to merge 1 commit into
nicolasLuduena wants to merge 1 commit into
Conversation
…ding Two preprod blocks from epoch 313, kept as raw fixtures under test_data/preprod/blocks and run through CardanoIndexDeltaBuilder::index_block: - 5183974: a native script nested 5384 levels deep, which overflowed the stack in pallas < 1.2 (txpipe/pallas#802) - 5184855: an N-of-K native script with N = -1, which failed with `expected u32` in pallas < 1.2 (txpipe/pallas#803) Both must index cleanly since the Haskell node accepts them; the tests guard the pallas 1.2 bump from #1358 against regressing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1358. Adds regression coverage for the two preprod blocks (epoch 313) that crashed dolos on pallas 1.1.1:
bac16602…)8ddb2e96…)unexpected type i8 … expected u32The raw blocks live in
crates/cardano/test_data/preprod/blocks/<hash>.cbor(46 KB total, same layout asmainnet/update_proposal_blocks) and are run throughCardanoIndexDeltaBuilder::index_block, the sync-path code that walks witness scripts, asserting the script hash lands in the archive index. Verified both tests fail on 1.1.1 and pass on 1.2.0.Note for follow-up: sync is fine, but the serving side still recurses over these scripts — minibf
/scripts/{hash}/json(NativeScript::to_json) and the u5c mapper — and will overflow the request thread's stack for block 5183974. That's a separate issue.🤖 Generated with Claude Code