Skip to content

chore: fix import ordering in generated tests#247

Merged
xldenis merged 1 commit into
nextfrom
xldenis/fix-import-ordering
Jul 3, 2026
Merged

chore: fix import ordering in generated tests#247
xldenis merged 1 commit into
nextfrom
xldenis/fix-import-ordering

Conversation

@xldenis

@xldenis xldenis commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

The generator inserted the ShardingConfig import before Schema in three test files, which fails the ktfmt lint check on next and blocks the 2.5.0 release PR (#246).

Ran scripts/gen + ./gradlew formatKotlin formatJava; this import reorder is the only resulting diff (CustomTypes.kt regenerated identically).

🤖 Generated with Claude Code

The generator inserted the ShardingConfig import before Schema,
which fails the ktfmt lint check.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@xldenis xldenis enabled auto-merge (squash) July 3, 2026 19:28
@xldenis xldenis merged commit 1e75734 into next Jul 3, 2026
8 checks passed
@xldenis xldenis deleted the xldenis/fix-import-ordering branch July 3, 2026 19:28
@stainless-app stainless-app Bot mentioned this pull request Jul 3, 2026
stainless-app Bot pushed a commit that referenced this pull request Jul 3, 2026
The generator inserted the ShardingConfig import before Schema,
which fails the ktfmt lint check.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@benesch

benesch commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Super annoying that the generator got this wrong.

@benesch

benesch commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Ohh, it's probably because the Row and Schema imports are already custom code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants