Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After the native folder picker has returned, Add Workspace may still wait for command presets. Pressing Escape closes the picking dialog, but its still-active continuation later reopens confirmation when that older response arrives. AppOverlays intentionally retains the flow component after first use, so unmount cleanup does not retire this dismissed request.
Approach
Expose the existing effect cancellation closure through a ref and invoke it from the common cancel handler. Route picking dismissal and demo close through that handler. Keep trigger-replacement/unmount cleanup and API/store behavior unchanged. One UI owner file changes.
Validation
New checks on 2026-10-09 against main f8f1343:
Runnable browser proof is retained outside the production diff under the current UI testing exception. An initial GREEN diagnostic stopped on an incorrect hidden-input textContent assertion; the proof was corrected to inputValue without changing the product, then controls passed.
Not run: real OS picker, Windows/mobile/real-device/layout acceptance, demo interaction, successful workspace creation/persistence, full pnpm test, whole-project tsc, release/package/native matrix. Workspace transition proof is an actual AppOverlays prop rerender, not full sidebar navigation. Existing build/style warnings retained; no full-suite or remote-CI pass claimed.