Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A valid finite agent timeout above Node's signed 32-bit timer limit (for example agent('wait', { timeoutMs: 2147483648 })) overflows to 1 ms. The actual workflow VM/dispatcher therefore fails almost immediately instead of waiting for a report.
Approach
Clamp finite per-agent delays to the existing MAX_WORKFLOW_DURATION_MS. The enclosing workflow is already bounded by that duration, so this reuses the existing limit rather than introducing a new policy. Keep ordinary/default/invalid-input behavior and timer cancellation ownership unchanged.
Add seven integration cases through the real workflow VM/executor, native timers, SQLite, PTY and HTTP report/stop routes. The passive CLI fixture does not contact a provider.
Validation
New checks on 2026-10-09, Node 24.19.0, main f8f1343:
CI selects the full/native platform and package matrix; those remote jobs are not locally verified. No 25-day expiration was awaited: the native overflow boundary is tested with delayed reports and cancellation/outer-budget controls. No real provider, browser/mobile or release publication validation is claimed. Existing trust-store EROFS and inactive-PTY cancellation diagnostics are retained; no permission changes were made.