Skip to content

fix: ignore superseded workflow schedule reads #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ooiuuii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ignore superseded workflow schedule reads #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions web/src/workflows/useWorkflowsPolling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export const useWorkflowsPolling = ({
const [error, setError] = useState<string | null>(null)
const [loading, setLoading] = useState(false)
const cancelledRef = useRef(false)
const scheduleRequestRef = useRef(0)
const timerRef = useRef<ReturnType<typeof setTimeout> | null>(null)

const fetchRuns = useCallback(async () => {
Expand All @@ -49,11 +50,14 @@ export const useWorkflowsPolling = ({

const fetchSchedules = useCallback(async () => {
if (!workspaceId) return
// An older list can predate a pause/resume already reconciled by a newer read.
const request = ++scheduleRequestRef.current
try {
const next = await listWorkflowSchedules(workspaceId)
if (!cancelledRef.current) setSchedules(next)
if (!cancelledRef.current && request === scheduleRequestRef.current) setSchedules(next)
} catch (e) {
if (!cancelledRef.current) setError(e instanceof Error ? e.message : String(e))
if (!cancelledRef.current && request === scheduleRequestRef.current)
setError(e instanceof Error ? e.message : String(e))
}
}, [workspaceId])

Expand All @@ -72,6 +76,7 @@ export const useWorkflowsPolling = ({
}, [fetchSchedules])

useEffect(() => {
scheduleRequestRef.current += 1
cancelledRef.current = false
if (!enabled || !workspaceId) {
return () => {
Expand Down