Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Custom startup commands lose shell-significant whitespace before launch. A harmless
printfending in backslash-plus-space prints a trailing space when executed directly, but Hive's real PTY prints a backslash because the resolver/parser trim the payload.Forward the original string through the worker resolver, parser and ordinary orchestrator path. Keep trimming only for empty-input checks and CLI/preset identification; shell flags, argument augmentation, permissions and recovery policies are unchanged.
Testing
pnpm checkandgit diff --checkpassed. Product files were unchanged by those refinements; the earlierpnpm buildpassed.agent_start.ok=false.The old parser assertion now expects the original padded command instead of normalized text, matching the corrected execution contract.
Self-Review
Four independent scoped reviews: architecture A, correctness A-, test quality B+ improved to A-, spec alignment A. No blocking product finding.
Accepted test findings were fixed: cleanup now attempts every server close and restores environment/fixtures in finally while surfacing failures; a Windows padded-payload unit was added. Reviewer C rechecked only those changes. Other source reviews remain applicable because product hashes did not change. Aggregate A-. Reviewers did not independently rerun runtime tests; command receipts and validation evidence are retained.