Repository navigation
fix: align eligible lifecycle return ports as a group - #760
outlier27-cell wants to merge 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 SummaryAt base Walkthrough
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk is established; the change is mergeable with normal follow-up for broader showcase validation. 🚥 Pre-merge checks | ✅ 1 | ❓ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
Full details: Validation EvidenceExplanation Public evidence is strong, but coverage is incomplete for the stated acceptance scope. The evaluated range is base Resolution When the private inputs are available, run the showcase artifact check on all ten inputs and record the final-head revision and results. Run the canonical Node 22 ZIP freshness check and retain its receipt. Keep the public focused-test and generated-artifact evidence, but label it as public coverage only.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # archify.zip
Problem and value
Fixes #739. The bundled Agent Run gives Reviewing/Blocked reciprocal transitions unnecessary 40 px jogs even though both upper ports fit Blocked. Align an entire lower-state top-port group only when all final positions fit its boundary, retain left-to-right order, and retain minimum port spacing. Evaluate final neighbor positions before moving any member.
Stability impact
Local lifecycle layout change. Brackets and groups which cannot all align retain the existing routing fallback. Upper ports, layout mode selection, label placement and collision gates remain authoritative. The Agent Run canvas stays 1152 x 500; Executing/Approval and Executing/Failed route coordinates remain unchanged.
Tests run
node --test test/lifecycle-layout.test.mjs: 16/16 passed, including both public v3 examples, straight Reviewing/Blocked reciprocal paths, unchanged four mixed-fit routes, shared exits, parallel transitions, label clearance and showcase artifact checks.Visual evidence
The committed README lifecycle image shows the resulting straight Blocked connections. Before: Reviewing/Blocked routes
801,92;801,144;841,144;841,202and867,202;867,126;827,126;827,92. After:801,92;801,202and827,202;827,92.Generated artifacts
Regenerated both checked-in lifecycle HTML copies, gallery artifact and receipts, README PNG, and
archify.zipusing official Node 22.