Repository navigation
fix(timeline): preserve historical calendar years in UTC offsets - #755
outlier27-cell wants to merge 5 commits into
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⛔ Files ignored due to path filters (1)
⚙️ Run configuration
⛔ Files ignored due to path filters (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 SummaryHistorical timestamps in years 0000–0099 could produce impossible UTC offsets because The reviewed base/head and CI status are not supplied. The author reports 10/10 tests on the candidate, but the tested revision is not identified here. No browser or perceptual acceptance is claimed. WalkthroughTimezone formatting now requests an era and converts BC years to astronomical year numbering. Offset calculation uses date setters to preserve years below 100. A rendering regression test checks UTC output for years 0000, 0001, 0099, 0100, and 2026. Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change addresses historical-year UTC offset formatting. No supported issue remains that should prevent merging. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…rly-year # Conflicts: # archify.zip
# Conflicts: # archify.zip
Problem and value
Fixes #753.
Timeline accepted historical timestamps but calculated impossible UTC offsets because
Date.UTCremaps years 0-99. Construct the wall-clock UTC date withsetUTCFullYear, and include era when reading Intl parts so ISO year zero is represented correctly.Stability impact
Local Timeline date formatting. Normal date, event ordering, axis positioning, and timezone choices remain unchanged. Historical valid dates now show the actual offset instead of thousands of hours.
Tests run
61425f56: year 0001 in UTC renders offsetUTC+16655040:00.node --test test/timeline-rendering.test.mjs: 10/10 passed on candidate, including years 0000, 0001, 0099, 0100, and 2026, existing timezone cases, and public examples through the showcase checker.Generated artifacts
archify.ziprebuilt from tracked candidate source using official Node 22. Modern bundled example inputs are unchanged.