Fix reduction sink root-relative paths - #147
Open
imlvts wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Relevant speed regression tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address #142
Changes:
Added
sink_template_prefixto derive write roots from the sink template rather than the entire sink expression.Fixed both fixed and ignored-variable paths in:
CountSinkHashSinkAndSinkSumSinkFloatReductionSinkEach now strips
wz.root_prefix_path()before callingmove_to_path.Reused the template-prefix logic for
PureSink.The optional
WASMSinkhad the same unstripped output-path issue, plus stale method signatures that prevented the feature from compiling. Its resource handling and root-relative output path are now corrected.