Skip to content

close modified document without saved will always remove the tab whenever user choose cancel or not save #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhouliangyi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

close modified document without saved will always remove the tab whenever user choose cancel or not save #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tabbar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,12 @@ void TabBar::closeTab(int index)
if (index < 0 || index >= m_editors.size())
return;

Core::EditorManager::instance()->closeEditor(m_editors.takeAt(index));
removeTab(index);
// error if user click close button to close a document which is modified and not saved,
// this call will defalt call closeEditor with closeEditor(IEditor *editor, bool askAboutModifiedEditors = true)
// if user chose "cancel", the Core::EditorManager won't close the editor, TabBar use takeAt will remove the editor from
// the container m_editors and call removeTab() to remove from QTabBar
Core::EditorManager::instance()->closeEditor(m_editors.value(index));

}

void TabBar::prevTabAction()
Expand Down