Repository navigation
ci: move actions to majors that run on Node 24 - #55
Merged
Merged
Conversation
GitHub has been forcing the v4 pins onto Node 24 with a deprecation warning in every job, so the pinned version no longer described what ran, and CI would break on whatever PR was open when the shim is withdrawn. setup-xcode@v1 already targets node24 and stays. .nvmrc is untouched: it sets the Node that builds lib/ and publishes, which is a separate change. Closes #41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41.
GitHub has been forcing the v4 action pins onto Node 24, with a
Node.js 20 is deprecatedwarning in all five CI jobs and in the release-please job. That meant the pinned version no longer described what actually ran, and the shim's eventual withdrawal would turn into a red check on whichever PR happened to be open.actions/checkoutactions/setup-nodeactions/cache(+/restore,/save)actions/setup-javagoogleapis/release-please-actionmaxim-lobanov/setup-xcodeRelease notes for each major were checked against how this repo uses them:
yarn@3.6.4, so nothing new turns on.NODE_AUTH_TOKEN. The publish step setsNODE_AUTH_TOKENitself, so the.npmrcit writes still resolves.pull_request_target/workflow_run. This repo usespull_request..nvmrc(v20.19.0) is deliberately untouched. It's the Node that buildslib/and runsnpm publish, so changing it is a separate decision (see the plan).Verification: this PR's CI must show zero
Node.js 20 is deprecatedlines.release.ymlonly runs onmain, so release-please@v5 gets verified on the push after merge (the Release PR should update), and the publish path on the next release.