Repository navigation
ci: make release-notes failures visible and re-runnable - #53
Merged
Merged
Conversation
The Release workflow's notes step is best-effort and runs after npm publish, so when it fails - as it did for 0.2.9, on an empty API credit balance - re-running that job would try to publish the same version again and stop before reaching the notes. This runs only the notes script, for a tag given at dispatch.
The notes step sat inside the publish job with continue-on-error, so when it failed for 0.2.9 the run still showed green and the failure went unnoticed, and re-running the job would have tried npm publish again. As a separate job without continue-on-error, a failure is visible, the release is unaffected, and "Re-run failed jobs" retries only the notes. The publish job no longer edits the release, so it drops to read access.
tristanheilman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Release workflow's AI-notes step is
continue-on-errorand runs afternpm publish. For 0.2.9 it failed: the Anthropic API returned "credit balance is too low". The release published fine but kept release-please's plain notes. Re-running that job can't recover the notes either, becausenpm publishrefuses a version that already exists and the job stops before the notes step.What changed
release.yml: the notes now run as their ownnotesjob, afterpublishand withoutcontinue-on-error.publishno longer edits the release, so it drops tocontents: read..github/workflows/release-notes.yml: a manual workflow (workflow_dispatch, with a requiredtaginput) for releases cut before the split, such as 0.2.9. It runs only.github/scripts/ai-release-notes.shfor that tag. Same script and same secret as the Release workflow;contents: writelets it edit the release.docs/agent/log.md: the 0.2.9 entry, including how to use this workflow.After merge
gh workflow run release-notes.yml -f tag=v0.2.9regenerates 0.2.9's notes (the API credits have since been topped up).Both workflows pass action-validator. CI-only, no package change.