Skip to content

chore: remove unused deps - #4651

Closed
carderne wants to merge 1 commit into
mainfrom
chore/knip-unused-deps
Closed

chore: remove unused deps#4651
carderne wants to merge 1 commit into
mainfrom
chore/knip-unused-deps

Conversation

@carderne

Copy link
Copy Markdown
Collaborator

With knip.

Enforced in CI now.

@changeset-bot

changeset-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f9e07f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62614e92-68d5-4801-9e0e-f892f1c7a966

📥 Commits

Reviewing files that changed from the base of the PR and between 6e77102 and f9e07f6.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (22)
  • .github/workflows/code-quality.yml
  • apps/webapp/package.json
  • internal-packages/cache/package.json
  • internal-packages/database/package.json
  • internal-packages/emails/package.json
  • internal-packages/otlp-importer/package.json
  • internal-packages/run-store/package.json
  • internal-packages/schedule-engine/package.json
  • internal-packages/sdk-compat-tests/package.json
  • internal-packages/sso/package.json
  • internal-packages/testcontainers/package.json
  • internal-packages/tsql/package.json
  • knip.json
  • package.json
  • packages/build/package.json
  • packages/cli-v3/package.json
  • packages/core/package.json
  • packages/python/package.json
  • packages/react-hooks/package.json
  • packages/redis-worker/package.json
  • packages/rsc/package.json
  • packages/trigger-sdk/package.json
💤 Files with no reviewable changes (14)
  • packages/python/package.json
  • internal-packages/emails/package.json
  • internal-packages/otlp-importer/package.json
  • internal-packages/schedule-engine/package.json
  • internal-packages/cache/package.json
  • packages/redis-worker/package.json
  • internal-packages/database/package.json
  • packages/rsc/package.json
  • internal-packages/testcontainers/package.json
  • apps/webapp/package.json
  • packages/core/package.json
  • packages/build/package.json
  • packages/cli-v3/package.json
  • internal-packages/sso/package.json

Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (34)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
  • GitHub Check: sdk-compat / Node.js 26.4 (warp-ubuntu-latest-x64-4x)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
  • GitHub Check: sdk-compat / Node.js 24.18 (warp-ubuntu-latest-x64-4x)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
  • GitHub Check: sdk-compat / Node.js 22.23 (warp-ubuntu-latest-x64-4x)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
  • GitHub Check: e2e / 🧪 CLI v3 tests (warp-windows-latest-x64-8x - npm)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
  • GitHub Check: e2e / 🧪 CLI v3 tests (warp-windows-latest-x64-8x - pnpm)
  • GitHub Check: sdk-compat / Deno Runtime
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
  • GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - pnpm)
  • GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
  • GitHub Check: sdk-compat / Cloudflare Workers
  • GitHub Check: sdk-compat / Node.js 20.20 (warp-ubuntu-latest-x64-4x)
  • GitHub Check: e2e / 🧪 CLI v3 tests (warp-ubuntu-latest-x64-4x - npm)
  • GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
  • GitHub Check: internal / 🧪 Unit Tests: Internal
  • GitHub Check: sdk-compat / Bun Runtime
  • GitHub Check: fk-cascade-guard / fk-cascade-guard
  • GitHub Check: runops-guard / runops-guard
  • GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
  • GitHub Check: code-quality / code-quality
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Build and publish previews
🧰 Additional context used
📓 Path-based instructions (1)
**/package.json

📄 CodeRabbit inference engine (AGENTS.md)

Adding dependencies: Edit package.json directly instead of using pnpm add, then run pnpm i from the repo root.

Files:

  • internal-packages/sdk-compat-tests/package.json
  • packages/trigger-sdk/package.json
  • internal-packages/tsql/package.json
  • internal-packages/run-store/package.json
  • packages/react-hooks/package.json
  • package.json
🔇 Additional comments (9)
knip.json (1)

3-87: LGTM!

package.json (2)

25-25: LGTM!


78-78: LGTM!

.github/workflows/code-quality.yml (1)

40-41: LGTM!

internal-packages/run-store/package.json (1)

17-21: LGTM!

internal-packages/sdk-compat-tests/package.json (1)

12-12: LGTM!

internal-packages/tsql/package.json (1)

9-9: LGTM!

packages/react-hooks/package.json (1)

51-51: LGTM!

packages/trigger-sdk/package.json (1)

81-81: LGTM!


Walkthrough

The pull request adds repository-wide Knip configuration and runs dependency analysis in the code-quality workflow. It removes unused runtime, development, type, testing, build, and OpenTelemetry dependencies across applications and packages. It also reclassifies dependencies in selected package manifests and adds @playwright/test to webapp development dependencies.

Merge Risk: ⚪ Minimal · up to f9e07

This change removes unused dependencies and enforces that cleanup in CI; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the dependency cleanup and CI enforcement but omits the required checklist, testing details, changelog, and screenshots sections. Add the required template sections and complete the checklist, testing steps, changelog entry, and screenshots section.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing unused dependencies and enforcing the related check.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/knip-unused-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne carderne closed this Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant