docs: add task-level and config-level TTL documentation#3200
docs: add task-level and config-level TTL documentation#3200matt-aitken merged 3 commits intomainfrom
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds and expands documentation for a Time-To-Live (TTL) option across multiple docs: project-level default Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/tasks/overview.mdx (1)
143-151: Code example should include the import statement for completeness.Per coding guidelines, code examples should be complete and runnable where possible. The example is missing the
taskimport.📝 Suggested fix
```ts /trigger/time-sensitive-task.ts +import { task } from "@trigger.dev/sdk"; + export const timeSensitiveTask = task({ id: "time-sensitive-task", ttl: "10m", // Also accepts a number of seconds, e.g. 600 run: async (payload: any, { ctx }) => { //... }, });</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@docs/tasks/overview.mdxaround lines 143 - 151, The code example defining
timeSensitiveTask is missing the required import; add an import for the task
factory (e.g., import { task } from "@trigger.dev/sdk";) at the top of the
snippet so the timeSensitiveTask = task({ ... }) example is complete and
runnable.</details> </blockquote></details> </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary>Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In@docs/tasks/overview.mdx:
- Around line 143-151: The code example defining timeSensitiveTask is missing
the required import; add an import for the task factory (e.g., import { task }
from "@trigger.dev/sdk";) at the top of the snippet so the timeSensitiveTask =
task({ ... }) example is complete and runnable.</details> --- <details> <summary>ℹ️ Review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: Repository UI **Review profile**: CHILL **Plan**: Pro **Run ID**: `b0e3436b-fbf2-410c-be4c-874b7458d12e` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between b3cebee3b3c0e2f95034ed58dabceebff4ca4ff2 and 05058c580933df91245cc0b8640302f6cc4116f3. </details> <details> <summary>📒 Files selected for processing (3)</summary> * `docs/config/config-file.mdx` * `docs/runs.mdx` * `docs/tasks/overview.mdx` </details> <details> <summary>🚧 Files skipped from review as they are similar to previous changes (2)</summary> * docs/config/config-file.mdx * docs/runs.mdx </details> </details> <details> <summary>📜 Review details</summary> <details> <summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)</summary> * GitHub Check: Analyze (javascript-typescript) </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>📓 Path-based instructions (1)</summary> <details> <summary>docs/**/*.mdx</summary> **📄 CodeRabbit inference engine (docs/CLAUDE.md)** > `docs/**/*.mdx`: MDX documentation pages must include frontmatter with title (required), description (required), and sidebarTitle (optional) in YAML format > Use Mintlify components for structured content: <Note>, <Warning>, <Info>, <Tip>, <CodeGroup>, <Expandable>, <Steps>/<Step>, <Card>/<CardGroup> > Always import from `@trigger.dev/sdk` in code examples (never from `@trigger.dev/sdk/v3`) > Code examples must be complete and runnable where possible > Use language tags in code fences: `typescript`, `bash`, `json` Files: - `docs/tasks/overview.mdx` </details> </details><details> <summary>🧠 Learnings (12)</summary> <details> <summary>📓 Common learnings</summary>Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3200
File: docs/config/config-file.mdx:353-368
Timestamp: 2026-03-10T12:44:19.869Z
Learning: In the triggerdotdev/trigger.dev repository, docs PRs are often written as companions to implementation PRs (e.g., PR#3200documents features being added in PR#3196). When reviewing docs PRs, the documented features may exist in a companion/companion PR branch rather than main. Always check companion PRs referenced in the PR description before flagging missing implementations.Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to /trigger//*.{ts,tsx,js,jsx} : Limit task execution time using themaxDurationoption (in seconds)Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to /trigger//*.{ts,tsx,js,jsx} : Useschedules.task()for scheduled (cron) tasks with either declarative cron patterns or imperative schedule creationLearnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to trigger.config.ts : Define global lifecycle hooks (onStart,onSuccess,onFailure) intrigger.config.tsto apply to all tasks</details> <details> <summary>📚 Learning: 2026-03-25T15:29:25.853Z</summary>Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to /trigger//*.{ts,tsx,js,jsx} : Limit task execution time using themaxDurationoption (in seconds)**Applied to files:** - `docs/tasks/overview.mdx` </details> <details> <summary>📚 Learning: 2026-03-25T15:29:25.853Z</summary>Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to /trigger//*.{ts,tsx,js,jsx} : Useschedules.task()for scheduled (cron) tasks with either declarative cron patterns or imperative schedule creation**Applied to files:** - `docs/tasks/overview.mdx` </details> <details> <summary>📚 Learning: 2026-03-25T15:29:25.853Z</summary>Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to /trigger//*.{ts,tsx,js,jsx} : Usetask()fromtrigger.dev/sdkfor basic task definitions withidandrunproperties**Applied to files:** - `docs/tasks/overview.mdx` </details> <details> <summary>📚 Learning: 2026-03-25T15:29:25.853Z</summary>Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to trigger.config.ts : Define global lifecycle hooks (onStart,onSuccess,onFailure) intrigger.config.tsto apply to all tasks**Applied to files:** - `docs/tasks/overview.mdx` </details> <details> <summary>📚 Learning: 2026-03-25T15:29:25.853Z</summary>Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to /trigger//*.{ts,tsx,js,jsx} : Use lifecycle hooks (init,cleanup,onStart,onSuccess,onFailure,handleError) to manage task execution stages**Applied to files:** - `docs/tasks/overview.mdx` </details> <details> <summary>📚 Learning: 2026-03-25T15:29:25.853Z</summary>Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to /trigger//*.{ts,tsx,js,jsx} : Usetask.trigger()to trigger a single run of a task from inside another task**Applied to files:** - `docs/tasks/overview.mdx` </details> <details> <summary>📚 Learning: 2026-03-25T15:29:25.853Z</summary>Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to /trigger//*.{ts,tsx,js,jsx} : Configure retry behavior using theretryoption with properties likemaxAttempts,factor,minTimeoutInMs,maxTimeoutInMs, andrandomize**Applied to files:** - `docs/tasks/overview.mdx` </details> <details> <summary>📚 Learning: 2026-03-25T15:29:25.853Z</summary>Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to /trigger//*.{ts,tsx,js,jsx} : Usetask.batchTrigger()to trigger multiple runs of a task from inside another task**Applied to files:** - `docs/tasks/overview.mdx` </details> <details> <summary>📚 Learning: 2026-03-25T15:29:25.853Z</summary>Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to trigger.config.ts : Configure the Trigger.dev project usingdefineConfig()with properties likeproject,dirs,retries,runtime, andbuild**Applied to files:** - `docs/tasks/overview.mdx` </details> <details> <summary>📚 Learning: 2026-03-25T15:29:25.853Z</summary>Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.853Z
Learning: Applies to /trigger//*.{ts,tsx,js,jsx} : Usetask.triggerAndWait()to trigger a task and wait for its result from inside another task**Applied to files:** - `docs/tasks/overview.mdx` </details> <details> <summary>📚 Learning: 2026-03-10T12:44:14.176Z</summary>Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3200
File: docs/config/config-file.mdx:353-368
Timestamp: 2026-03-10T12:44:14.176Z
Learning: In the trigger.dev repo, docs PRs are often companions to implementation PRs. When reviewing docs PRs (MDX files under docs/), check the PR description for any companion/related PR references and verify that the documented features exist in those companion PRs before flagging missing implementations. This ensures docs stay in sync with code changes across related PRs.**Applied to files:** - `docs/tasks/overview.mdx` </details> </details> </details> <details> <summary>🔇 Additional comments (1)</summary><blockquote> <details> <summary>docs/tasks/overview.mdx (1)</summary><blockquote> `139-154`: **LGTM!** The `ttl` option documentation is well-structured, follows the existing patterns in the file, and provides clear guidance on usage with appropriate cross-references to related documentation. The three-tier precedence explanation and `ttl: 0` opt-out behavior are documented as intended. </blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Add TTL (time-to-live) defaults at task-level and config-level, with precedence: per-trigger > task > config > dev default (10m). Docs PR: #3200 (merge after packages are released)
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
2 participants
Documents TTL support at task-level and config-level. Companion to #3196 - merge after new packages are released.