Skip to content

Add e2e tests for AI settings clean up#4452

Merged
nelsonkopliku merged 4 commits into
mainfrom
clear-ai-settings-e2e
Jul 3, 2026
Merged

Add e2e tests for AI settings clean up#4452
nelsonkopliku merged 4 commits into
mainfrom
clear-ai-settings-e2e

Conversation

@nelsonkopliku

Copy link
Copy Markdown
Member

Description

E2E tests for AI Configuration clean up.

How was this tested?

THIS IS THE TEST.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Cypress E2E coverage for the “AI Configuration clean up” flow on the user profile page, validating the new “Clear Settings” UI behavior and the DELETE request path.

Changes:

  • Add new page-object selectors and helpers to interact with the AI configuration “Clear Settings” button and confirmation modal.
  • Extend existing AI Configuration E2E assertions to cover clear-button enabled/disabled states.
  • Add two new E2E scenarios to verify dismissing vs confirming the clear-configuration modal.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
test/e2e/cypress/pageObject/users_po.js Adds Cypress selectors and helper functions for clearing AI configuration (button state, modal open/close, confirm/cancel).
test/e2e/cypress/e2e/users.cy.js Adds E2E test coverage for AI configuration clearing behavior and button state expectations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/e2e/cypress/pageObject/users_po.js Outdated
@nelsonkopliku nelsonkopliku added this to the 3.2.0 milestone Jul 2, 2026

@vicenteqa vicenteqa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just some minor stuff :)

Comment thread test/e2e/cypress/e2e/users.cy.js Outdated
'gemini-2.5-pro',
'test-api-key'
)
.then(() => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this  .then()  is not needed here since we are not using the returned value. apiCreateAIConfiguration()  already returns the Cypress chain, so the following commands will be queued after it

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I addressed here d257bce and adjusted other tests that had the unnecessary then

Comment thread test/e2e/cypress/e2e/users.cy.js Outdated
Comment thread test/e2e/cypress/pageObject/users_po.js Outdated
@nelsonkopliku nelsonkopliku force-pushed the clear-ai-settings-ui branch from c9d6c79 to a23de44 Compare July 3, 2026 07:28
Base automatically changed from clear-ai-settings-ui to main July 3, 2026 07:29
nelsonkopliku and others added 4 commits July 3, 2026 09:36
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@nelsonkopliku nelsonkopliku force-pushed the clear-ai-settings-e2e branch from d257bce to bce82a1 Compare July 3, 2026 07:36
@nelsonkopliku nelsonkopliku merged commit 1a58ec7 into main Jul 3, 2026
97 of 98 checks passed
@nelsonkopliku nelsonkopliku deleted the clear-ai-settings-e2e branch July 3, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request test

Development

Successfully merging this pull request may close these issues.

5 participants