Use stale value instance status#4448
Open
arbulu89 wants to merge 5 commits into
Open
Conversation
arbulu89
commented
Jul 2, 2026
| import CollapsibleTableRow from './CollapsibleTableRow'; | ||
|
|
||
| const defaultCellRender = (content) => ( | ||
| <p className="text-gray-900 whitespace-no-wrap">{content}</p> |
Contributor
Author
There was a problem hiding this comment.
This change is done to give the option to render cells text color dynamically. The default color now is in the table class
|
🎉 All dependencies have been resolved ! |
arbulu89
force-pushed
the
use-stale-value-instance-status
branch
from
df44233 to
b1d9340
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR wires the new “stale” metadata (from the dependent PR #4441) into the UI by passing staleAt and the user/profile timezone down to InstanceStatus, and by applying a shared “stale row” styling across several instance tables/rows.
Changes:
- Propagate
timezonefromgetUserProfile(and fromHostDetailsprops) into multiple overview/detail components and table configs. - Pass
stale_at+timezoneintoInstanceStatusso the tooltip can show “Stale since …” in the intended timezone. - Introduce a shared
STALE_ROWclass and apply it to rows; adjust default Table text color handling.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| assets/js/pages/SapSystemsOverviewPage/SapSystemsOverviewPage.jsx | Pulls timezone from profile and passes it into the overview page component. |
| assets/js/pages/SapSystemsOverviewPage/SapSystemsOverview.jsx | Accepts userTimezone and passes it to the SAP system item details renderer. |
| assets/js/pages/SapSystemDetails/tableConfigs.jsx | Applies STALE_ROW/absent styling at row-level; passes staleAt + timezone into InstanceStatus; adds host-row stale styling. |
| assets/js/pages/SapSystemDetails/SapSystemDetails.jsx | Pulls timezone from profile and forwards it into system details. |
| assets/js/pages/SapSystemDetails/GenericSystemDetails.jsx | Plumbs userTimezone into the instances table configuration. |
| assets/js/pages/SapSystemDetails/GenericSystemDetails.test.jsx | Adds UT coverage for stale-row styling in the instances table. |
| assets/js/pages/InstanceOverview/InstanceOverview.jsx | Uses STALE_ROW and passes staleAt + timezone into InstanceStatus. |
| assets/js/pages/InstanceOverview/InstanceOverview.test.jsx | Adds UT coverage for stale styling in the instance overview row. |
| assets/js/pages/HostDetailsPage/tableConfigs.jsx | Converts SAP instances table config to a factory so it can inject userTimezone; passes staleAt + timezone into InstanceStatus. |
| assets/js/pages/HostDetailsPage/HostDetails.jsx | Switches to the new SAP instances table config factory and supplies the timezone. |
| assets/js/pages/DatabasesOverview/DatabasesOverviewPage.jsx | Pulls timezone from profile and passes it into the databases overview. |
| assets/js/pages/DatabasesOverview/DatabasesOverview.jsx | Accepts userTimezone and forwards it to per-database item overviews. |
| assets/js/pages/DatabasesOverview/DatabaseItemOverview.jsx | Threads userTimezone down into InstanceOverview for database instances. |
| assets/js/pages/DatabaseDetails/DatabaseDetails.jsx | Pulls timezone from profile and forwards it into database details. |
| assets/js/lib/tables/index.js | Introduces shared STALE_ROW class constant. |
| assets/js/common/Table/Table.jsx | Centralizes default text color on <tbody> and simplifies the default cell renderer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
staleAtandtimezoneinInstanceStatuscomponents.Depends on: #4441
How was this tested?
UT
Documentation changes
No