Update instances stale state redux#4446
Open
arbulu89 wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the frontend Redux state to react to newly broadcast “stale” events for application/database instances, and extends the Activity Log model so new backend activity types render with proper labels/messages.
Changes:
- Add Redux slice actions + saga watchers/handlers to update
stale_atfor application and database instances. - Add reducer unit tests for the new
stale_atupdate actions. - Add new Activity Log type mappings for “data marked stale / in sync”.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| assets/js/state/sapSystems.test.js | Adds reducer test for updating stale_at on application instances. |
| assets/js/state/sapSystems.js | Adds updateApplicationInstanceStaleAt action + new stale-change event constant/action. |
| assets/js/state/sagas/sapSystems.js | Adds saga handler + watcher for APPLICATION_INSTANCE_STALE_CHANGED. |
| assets/js/state/sagas/databases.js | Adds saga handler + watcher for DATABASE_INSTANCE_STALE_CHANGED. |
| assets/js/state/sagas/channels.js | Registers new broadcast event names to dispatch stale-change actions. |
| assets/js/state/databases.test.js | Adds reducer test for updating stale_at on database instances. |
| assets/js/state/databases.js | Adds updateDatabaseInstanceStaleAt action + new stale-change event constant/action. |
| assets/js/lib/test-utils/factories/sapSystems.js | Updates application instance factory fields and adds stale_at. |
| assets/js/lib/test-utils/factories/databases.js | Updates database instance factory fields and adds stale_at. |
| assets/js/lib/model/activityLog.js | Adds Activity Log config for new “data marked stale / in sync” activity types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arbulu89
force-pushed
the
update-instances-stale-state-redux
branch
from
ce3ad8e to
8b470d4
Compare
arbulu89
force-pushed
the
update-instances-stale-state-redux
branch
from
8b470d4 to
26c97ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update redux store application and database instances from broadcasted messages.
And i have added the backend events in the activity log list to be displayed properly as well (the severity still needs to be changed).
How was this tested?
UT
Documentation changes
No