Skip to content

Update storybook#4239

Open
antgamdia wants to merge 35 commits into
mainfrom
update-storybook
Open

Update storybook#4239
antgamdia wants to merge 35 commits into
mainfrom
update-storybook

Conversation

@antgamdia

@antgamdia antgamdia commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Description

This PR runs an automated script (not ready as of today, it needs some polishing up, find them at 2af5625) to synchronize the component's properties with the ones in the stories. As we have been updating components, some properties no longer exist or some others were never added to the story.

See https://storybook.js.org/docs/api/arg-types

Next, I've used some LLMs to auto-perform some improvements over all the files.

For now, I'm just adding the properties... I'll get my friend Gemini to populate the descriptions in a second round 😅

Edit: note to myself: check empty argTypes: {}

How was this tested?

Building storybook manually.

Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
@antgamdia antgamdia added the javascript Pull requests that update Javascript code label Apr 30, 2026
@antgamdia antgamdia requested a review from arbulu89 April 30, 2026 17:34
@antgamdia antgamdia marked this pull request as ready for review April 30, 2026 17:34
antgamdia added 7 commits May 4, 2026 14:54
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>

@arbulu89 arbulu89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @antgamdia,
I went through some of the changes, but reviewing everything would take me the whole day.

Some comments:

  • Have a look into my comment of ordering imports.
  • We shouldn't have Default entries always, some cases don't make sense
  • We should use Default.args in many entries to avoid duplication

Comment thread assets/js/common/AbilitiesMultiSelect/AbilitiesMultiSelect.stories.jsx Outdated
Comment thread assets/js/common/AdvisoryIcon/AdvisoryIcon.stories.jsx
Comment thread assets/js/common/AIConfiguration/AIConfigurationModal.stories.jsx
Comment thread assets/js/common/AIProviderLabel/AIProviderLabel.stories.jsx
Comment thread assets/js/common/ClusterTypeLabel/ClusterTypeLabel.stories.jsx Outdated
Comment thread assets/js/common/DisabledGuard/DisabledGuard.stories.jsx Outdated
Comment thread assets/js/common/GenericError/GenericError.stories.jsx
Comment thread assets/js/common/HealthIcon/HealthIcon.stories.jsx Outdated
Comment thread assets/js/common/HostInfoBox/HostInfoBox.stories.jsx Outdated
antgamdia added 9 commits May 5, 2026 10:49
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
antgamdia added 2 commits May 5, 2026 20:11
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s Storybook stories to better reflect current component/page props by synchronizing argTypes/args across many stories, adding stories where missing, and making a few supporting adjustments in shared utilities.

Changes:

  • Added many new Storybook stories for pages/components that previously lacked them.
  • Normalized and expanded argTypes/args in existing stories (including wiring actions) to keep stories in sync with component APIs.
  • Extended factory exports and made a small safety tweak in DisabledGuard default props.

Reviewed changes

Copilot reviewed 201 out of 201 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
assets/js/pages/Users/UsersPage.stories.jsx New story for UsersPage container with mocked store/network.
assets/js/pages/Users/Users.stories.jsx Updated story args/argTypes and actions wiring for Users.
assets/js/pages/Users/EditUserPage.stories.jsx New story for EditUserPage with router + API mocks.
assets/js/pages/Users/CreateUserPage.stories.jsx New story for CreateUserPage with router decorator.
assets/js/pages/UpgradablePackagesPage/UpgradablePackages.stories.jsx Updated story meta/argTypes and action handlers.
assets/js/pages/TriggerChecksExecutionRequest/TriggerChecksExecutionRequest.stories.jsx New story with argTypes and action handler.
assets/js/pages/SSOCallback/SSOCallback.stories.jsx New story for SSO callback page with mocked store/router.
assets/js/pages/SomethingWentWrong/SomethingWentWrong.stories.jsx New story for error page with router decorator.
assets/js/pages/SaptuneDetails/SaptuneVersion.stories.jsx New story for SaptuneVersion.
assets/js/pages/SaptuneDetails/SaptuneTuningState.stories.jsx New story for tuning state pill/component.
assets/js/pages/SaptuneDetails/SaptuneServiceStatus.stories.jsx New story for service status component.
assets/js/pages/SaptuneDetails/SaptuneDetails.stories.jsx Updated argTypes control shapes for SaptuneDetails.
assets/js/pages/SapSystemsOverviewPage/SapSystemsOverviewPage.stories.jsx New page-level story with mocked store/router.
assets/js/pages/SapSystemsOverviewPage/SapSystemsOverview.stories.jsx Updated story meta/argTypes and added a Default story variant.
assets/js/pages/SapSystemsOverviewPage/SapSystemItemOverview.stories.jsx New story for system item overview component.
assets/js/pages/SapSystemDetails/InstanceStatus.stories.jsx New story for InstanceStatus.
assets/js/pages/SapSystemDetails/Features.stories.jsx New story for Features.
assets/js/pages/Profile/TotpEnrollmentBox.stories.jsx Updated controls and added action wiring for verify callback.
assets/js/pages/Profile/ProfilePasswordChangeForm.stories.jsx Updated argTypes and added a concrete Default story + variants.
assets/js/pages/Profile/ProfilePage.stories.jsx New ProfilePage story with mocked store/network.
assets/js/pages/NotFound/NotFound.stories.jsx Updated import path + argTypes/actions; converted to CSF object export.
assets/js/pages/Login/LoginSSO.stories.jsx New story for SSO login component.
assets/js/pages/Login/Login.stories.jsx New story for login container with mocked store/router.
assets/js/pages/Layout/Layout.stories.jsx New story for app layout with store/router scaffolding.
assets/js/pages/InstanceOverview/InstanceOverview.stories.jsx New story for instance overview component.
assets/js/pages/HostsList/HostsList.stories.jsx New story for HostsList with mocked store/router.
assets/js/pages/HostSettingsPage/HostSettingsPage.stories.jsx New story for HostSettingsPage with route params + store.
assets/js/pages/HostRelevantPatches/Page.stories.jsx New story for relevant patches page wrapper with mocked store/router.
assets/js/pages/HostRelevantPatches/HostRelevantPatchesPage.stories.jsx Updated story meta/argTypes and added a Default story.
assets/js/pages/HostDetailsPage/StatusPill.stories.jsx New story for StatusPill.
assets/js/pages/HostDetailsPage/SaptuneSummary.stories.jsx New story for SaptuneSummary with action handler.
assets/js/pages/HostDetailsPage/ProviderDetails.stories.jsx New story for provider details display.
assets/js/pages/HostDetailsPage/HostTimeSeriesLineChart.stories.jsx New story for host timeseries chart wrapper.
assets/js/pages/HostDetailsPage/HostSummary.stories.jsx New story for HostSummary.
assets/js/pages/HostDetailsPage/DiskSpaceChart.stories.jsx New story for disk chart component.
assets/js/pages/Home/Home.stories.jsx New Home story with mocked store/router.
assets/js/pages/HealthSummary/HomeHealthSummary.stories.jsx Updated story meta and added argTypes + Default args.
assets/js/pages/HealthSummary/HealthSummaryBox.stories.jsx New story for HealthSummaryBox.
assets/js/pages/HealthSummary/HealthSummary.stories.jsx New story for HealthSummary.
assets/js/pages/Guard/Guard.stories.jsx New story for route guard component with mocked store/router.
assets/js/pages/ExecutionResults/TargetResult.stories.jsx New story for target result row with action callback.
assets/js/pages/ExecutionResults/TargetInfoBox.stories.jsx New story for target info box.
assets/js/pages/ExecutionResults/ResultsContainer.stories.jsx New story for results container with sample data + actions.
assets/js/pages/ExecutionResults/ExecutionHeader.stories.jsx New story for execution header with router + actions.
assets/js/pages/ExecutionResults/ExecutionContainer.stories.jsx New story for execution container.
assets/js/pages/ExecutionResults/ChecksSelectionHints.stories.jsx New story for selection hints component.
assets/js/pages/ExecutionResults/ChecksResultFilters.stories.jsx New story for filters component with actions.
assets/js/pages/ExecutionResults/CheckResultDetail/GatheredFacts.stories.jsx Updated story to include argTypes for props.
assets/js/pages/ExecutionResults/CheckResultDetail/FactValue.stories.jsx New story for FactValue.
assets/js/pages/ExecutionResults/CheckResultDetail/ExpectedValues.stories.jsx Updated story with argTypes for props.
assets/js/pages/ExecutionResults/CheckResultDetail/ExpectationsResults.stories.jsx Updated story imports and argTypes/options for severity.
assets/js/pages/ExecutionResults/CheckResultDetail/CheckResultInfoBox.stories.jsx New story for CheckResultInfoBox.
assets/js/pages/ExecutionResults/CheckResultDetail/CheckResultDetail.stories.jsx Updated argTypes for CheckResultDetail.
assets/js/pages/ExecutionResults/CheckResultDetail/CheckDetailHeader.stories.jsx New story for CheckDetailHeader with router decorator.
assets/js/pages/ExecutionResults/CheckResultDetail/BackToTargetExecution.stories.jsx New story for back-link component with router.
assets/js/pages/ExecutionResults/BackToTargetDetails.stories.jsx New story for back-to-details link component.
assets/js/pages/DatabasesOverview/DatabaseItemOverview.stories.jsx New story for database item overview.
assets/js/pages/DatabaseDetails/DatabaseDetails.stories.jsx Updated story meta/argTypes and added Default args + actions.
assets/js/pages/ClusterDetails/SBDDetails.stories.jsx New story for SBD details component.
assets/js/pages/ClusterDetails/Resources.stories.jsx New story for cluster resources view.
assets/js/pages/ClusterDetails/ReplicationStatusPill.stories.jsx New story for replication pill variants.
assets/js/pages/ClusterDetails/HanaClusterSite.stories.jsx New story for HANA cluster site component.
assets/js/pages/ClusterDetails/ClusterStatePill.stories.jsx New story for cluster state pill.
assets/js/pages/ClusterDetails/ClustersList.stories.jsx New story for clusters list with mocked store/router.
assets/js/pages/ClusterDetails/ClusterNodeName.stories.jsx New story for node name component with variants.
assets/js/pages/ClusterDetails/ClusterNodeLink.stories.jsx New story for node link component.
assets/js/pages/ClusterDetails/ClusterLink.stories.jsx New story for cluster link component with variants.
assets/js/pages/ClusterDetails/AttributesDetails.stories.jsx New story for attributes details component.
assets/js/pages/ChecksSelection/ChecksSelectionItem.stories.jsx New story for selection item component with actions.
assets/js/pages/ChecksSelection/ChecksSelectionHeader.stories.jsx Updated argTypes/control shapes and added actions to args.
assets/js/pages/ChecksSelection/ChecksSelectionGroup.stories.jsx New story for selection group component.
assets/js/pages/ChecksSelection/ChecksSelection.stories.jsx Updated argTypes (provider/options) and wired action handlers.
assets/js/pages/ChecksCatalog/ChecksCatalogPage.stories.jsx New story for catalog page with mocked store + actions.
assets/js/pages/ChecksCatalog/ChecksCatalog.stories.jsx Updated argTypes and added richer Default args.
assets/js/pages/ChecksCatalog/CheckItem.stories.jsx New story for individual catalog item component.
assets/js/pages/ChecksCatalog/CatalogContainer.stories.jsx New story for catalog container and state variants.
assets/js/pages/CheckResultsOverview/CheckResultsOverview.stories.jsx Updated argTypes, added action handler, and expanded story variants.
assets/js/pages/CheckResultsOverview/CheckResultCount.stories.jsx New story for result count row variants.
assets/js/pages/AnalyticsEula/AnalyticsEulaModal.stories.jsx Updated argTypes/actions and converted to CSF object export.
assets/js/pages/AdvisoryDetails/AdvisoryDetailsPage.stories.jsx New story for advisory details with mocked store/router/network.
assets/js/pages/AboutPage/AboutPageText.stories.jsx New story for About page text component.
assets/js/pages/AboutPage/AboutPageLogo.stories.jsx New story for About page logo component.
assets/js/pages/AboutPage/AboutPage.stories.jsx Updated story import + argTypes; added factory-backed data.
assets/js/lib/test-utils/factories/index.js Exported additional factories through the index barrel.
assets/js/common/UpgradablePackagesList/UpgradablePackagesList.stories.jsx Updated argTypes and added actions + variants.
assets/js/common/Tooltip/Tooltip.stories.jsx Updated import path and expanded argTypes.
assets/js/common/TargetIcon/TargetIcon.stories.jsx Added argTypes and normalized args for variants.
assets/js/common/Tags/Tags.stories.jsx Updated story to use factories + expanded argTypes/actions.
assets/js/common/Table/SortingIcon.stories.jsx New story for sorting icon.
assets/js/common/Table/EmptyState.stories.jsx New story for empty state row.
assets/js/common/Table/CollapsibleTableRow.stories.jsx New story for collapsible row renderer.
assets/js/common/Switch/Switch.stories.jsx Updated import path and provided concrete default args/actions.
assets/js/common/SuseManagerConfig/CertificateUploadDate.stories.jsx New story for certificate upload date display.
assets/js/common/SuseManagerClearSettingsDialog/SuseManagerClearSettingsModal.stories.jsx Updated argTypes and wired actions.
assets/js/common/Spinner/Spinner.stories.jsx Normalized argTypes and added a CSF Default args object.
assets/js/common/SettingsLoader/SettingsLoader.stories.jsx Updated imports and normalized argTypes/actions.
assets/js/common/SapSystemLink/SapSystemLink.stories.jsx New story with router decorator.
assets/js/common/ResetCheckCustomizationModal/ResetCheckCustomizationModal.stories.jsx Updated import path, argTypes/actions, and added Closed variant.
assets/js/common/ProviderLabel/ProviderLabel.stories.jsx Updated to use providers list and added a Default story/variants.
assets/js/common/ProfileMenu/ProfileMenu.stories.jsx Updated import path, argTypes, and reworked render wrapper usage.
assets/js/common/PersonalAccessTokens/PersonalAccessTokens.stories.jsx Updated argTypes and added actions + timezone arg.
assets/js/common/PersonalAccessTokens/NewTokenModal.stories.jsx Updated argTypes and wired onClose action.
assets/js/common/PersonalAccessTokens/GenerateTokenModal.stories.jsx Updated argTypes and wired actions.
assets/js/common/PersonalAccessTokens/DeleteTokenModal.stories.jsx Updated argTypes and wired actions.
assets/js/common/PatchList/PatchList.stories.jsx Updated import path/meta and expanded argTypes/variants.
assets/js/common/Pagination/Pagination.stories.jsx Updated imports, argTypes, and story render wiring.
assets/js/common/Pagination/PageStats.stories.jsx New story for PageStats.
assets/js/common/PageHeader/PageHeader.stories.jsx New story for PageHeader.
assets/js/common/OperationModals/SapStartStopOperationModal.stories.jsx Updated argTypes and added explicit Default/variant args with actions.
assets/js/common/OperationModals/OperationModal.stories.jsx New story for base operation modal.
assets/js/common/OperationModals/OperationForbiddenModal.stories.jsx Updated argTypes, wired actions, and added explicit Default args.
assets/js/common/OperationModals/index.js Exported OperationModal from the barrel and reordered exports.
assets/js/common/ObjectTree/ObjectTreeNode.stories.jsx New story for object tree node component.
assets/js/common/ObjectTree/ObjectTreeIcon.stories.jsx New story for object tree icon component.
assets/js/common/ObjectTree/ObjectTree.stories.jsx Updated import path and converted function story to CSF objects.
assets/js/common/NotificationBox/NotificationBox.stories.jsx New story for notification box component.
assets/js/common/ModifiedCheckPill/ModifiedCheckPill.stories.jsx New story for modified pill component.
assets/js/common/Modal/Modal.stories.jsx New story for Modal.
assets/js/common/Markdown/Markdown.stories.jsx New story for markdown renderer.
assets/js/common/LoadingBox/LoadingBox.stories.jsx New story for loading box.
assets/js/common/ListView/ListView.stories.jsx Updated import path/argTypes and converted to CSF objects.
assets/js/common/Label/Label.stories.jsx Normalized control types and ensured variants spread Default args.
assets/js/common/Input/Password.stories.jsx Updated import path and added full argTypes + Default args.
assets/js/common/Input/InputNumber.stories.jsx New story for numeric input component.
assets/js/common/HostLink/HostLink.stories.jsx New story with router decorator.
assets/js/common/HostInfoBox/HostInfoBox.stories.jsx New story for host info display.
assets/js/common/GenericError/GenericError.stories.jsx Updated import path and converted to CSF objects.
assets/js/common/ForbiddenGuard/ForbiddenGuard.stories.jsx New story with mocked store.
assets/js/common/Filter/Filter.stories.jsx Updated import path and normalized argTypes/actions.
assets/js/common/FilesystemCharts/SwapUsageChart.stories.jsx Updated argTypes and ensured variants spread Default args.
assets/js/common/FilesystemCharts/MountpointsChart.stories.jsx Updated argTypes and ensured variants spread Default args.
assets/js/common/DottedPagination/DottedPagination.stories.jsx Updated import path/argTypes and added Default args + actions.
assets/js/common/DottedPagination/Arrow.stories.jsx New story for pagination arrow component.
assets/js/common/DismissableToast/NotificationsPlayground.stories.jsx Updated import order and converted to CSF object story.
assets/js/common/DisabledGuard/DisabledGuard.stories.jsx Updated import path and expanded argTypes + Default args.
assets/js/common/DisabledGuard/DisabledGuard.jsx Added default values for userAbilities/permitted props.
assets/js/common/DateFilter/DateFilter.stories.jsx Updated import path and expanded argTypes/options.
assets/js/common/CopyButton/CopyButton.stories.jsx Updated import path and normalized control config.
assets/js/common/ComposedFilter/ComposedFilter.stories.jsx Updated import path and normalized argTypes/actions + examples.
assets/js/common/ClusterTypeLabel/ClusterTypeLabel.stories.jsx New story for cluster type label component.
assets/js/common/ClusterInfoBox/ClusterInfoBox.stories.jsx New story for cluster info box component.
assets/js/common/CleanUpButton/CleanUpButton.stories.jsx Updated import path, argTypes, and concrete Default args/actions.
assets/js/common/CheckCustomizationModal/CheckCustomizationInput.stories.jsx New story for customization input component.
assets/js/common/CheckableWarningMessage/CheckableWarningMessage.stories.jsx Updated import path and converted to CSF objects + actions.
assets/js/common/ChartsFeatureWrapper/ChartsFeatureWrapper.stories.jsx New story for charts feature gating wrapper.
assets/js/common/ChartsDisabledBox/ChartsDisabledBox.stories.jsx Updated import path and added explicit argTypes.
assets/js/common/Banners/Banner.stories.jsx Normalized argTypes and ensured variants spread Default args.
assets/js/common/BackButton/BackButton.stories.jsx New story for BackButton with router decorator + actions.
assets/js/common/AvailableSoftwareUpdates/SumaNotConfigured.stories.jsx New story for “SUManager not configured” state.
assets/js/common/AvailableSoftwareUpdates/Loading.stories.jsx New story for loading state.
assets/js/common/AvailableSoftwareUpdates/Indicator.stories.jsx New story for updates indicator component with actions.
assets/js/common/ApiKeyBox/ApiKeyBox.stories.jsx New story for API key display box.
assets/js/common/AlertingSettingsModal/AlertingSettingsModal.stories.jsx Updated argTypes and added concrete Default args/actions.
assets/js/common/AlertingSettingsConfig/AlertingSettingsConfig.stories.jsx Updated imports, argTypes, and added Default args/variants.
assets/js/common/AIProviderLabel/AIProviderLabel.stories.jsx Updated import path and added Default args + variants.
assets/js/common/AIConfiguration/AIConfiguration.stories.jsx Updated argTypes to use actions and expanded args.
assets/js/common/AdvisoryIcon/AdvisoryIcon.stories.jsx Updated import path and added a Default story + normalized variants.
assets/js/common/ActivityLogsSettingsModal/ActivityLogsSettingsModal.stories.jsx Updated import path/argTypes and wired actions.
assets/js/common/ActivityLogsConfig/ActivityLogsConfig.stories.jsx Updated import path/argTypes and normalized actions/abilities.
assets/js/common/ActivityLogOverview/ActivityLogOverview.stories.jsx Updated control types and fixed naming of “Unknown” variant.
assets/js/common/ActivityLogDetailsModal/ActivityLogDetailModal.stories.jsx Updated import path, argTypes/actions, and fixed typos in descriptions/variant names.
assets/js/common/Accordion/Accordion.stories.jsx Updated import path and expanded argTypes.
assets/js/common/AbilitiesMultiSelect/AbilitiesMultiSelect.stories.jsx New story for abilities multi-select with actions and variants.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread assets/js/pages/ExecutionResults/CheckResultDetail/CheckDetailHeader.stories.jsx Outdated
Comment thread assets/js/pages/SaptuneDetails/SaptuneVersion.stories.jsx
Comment thread assets/js/pages/Users/UsersPage.stories.jsx Outdated
Comment thread assets/js/common/Tooltip/Tooltip.stories.jsx
Comment thread assets/js/pages/Users/EditUserPage.stories.jsx Outdated
@antgamdia antgamdia changed the title Update storybook [TRNT-4362] Update storybook May 7, 2026
antgamdia added 5 commits May 7, 2026 15:30
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
@antgamdia antgamdia changed the title [TRNT-4362] Update storybook Update storybook Jun 2, 2026
antgamdia added 3 commits July 1, 2026 15:37
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
antgamdia added 2 commits July 2, 2026 17:26
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code tech debt

Development

Successfully merging this pull request may close these issues.

3 participants