[TRNT-4339] Add SearchableSelect#4164
Conversation
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
arbulu89
left a comment
There was a problem hiding this comment.
hey @antgamdia
I'm fine using the react-select combobox option.
Could we maybe simply import the react-select here instead of changing MultiSelect?
We could export the multi select components to keep same styles.
PD:
I think we have a tech-debt here, where we should only have one Select element (instead of Select, MultiSelect and SearchableSelect, where we can make it multi or searchable through props). All of them with react-select. But this is something we can do afterwards
I'd rather not add another component, in the end this one does the same thing as |
TBD, will update once all the stacked PRs are ready.
Next PR: #4165
Description
Please include a summary of the changes and the related issue, if it exists.
Also, include relevant motivation and context for this PR. List any dependencies that are required for this change.
Fixes # (issue)
Did you add the right label?
Remember to add the right labels to this PR.
How was this tested?
Describe the tests that have been added/changed for this new behavior.
Did you update the documentation?
Remember to ask yourself if your PR requires changes to the following documentation:
User Documentation
Developer Documentation
Trento Web Documentation
DONE