Skip to content

[TRNT-4339] Add SearchableSelect#4164

Closed
antgamdia wants to merge 3 commits into
mainfrom
TRNT-4339-1
Closed

[TRNT-4339] Add SearchableSelect#4164
antgamdia wants to merge 3 commits into
mainfrom
TRNT-4339-1

Conversation

@antgamdia

@antgamdia antgamdia commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

TBD, will update once all the stacked PRs are ready.

Next PR: #4165

Description

Please include a summary of the changes and the related issue, if it exists.
Also, include relevant motivation and context for this PR. List any dependencies that are required for this change.

Fixes # (issue)

Did you add the right label?

Remember to add the right labels to this PR.

  • DONE

How was this tested?

Describe the tests that have been added/changed for this new behavior.

  • DONE

Did you update the documentation?

Remember to ask yourself if your PR requires changes to the following documentation:

Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
@antgamdia antgamdia added enhancement New feature or request javascript Pull requests that update Javascript code labels Apr 10, 2026

@arbulu89 arbulu89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @antgamdia
I'm fine using the react-select combobox option.
Could we maybe simply import the react-select here instead of changing MultiSelect?
We could export the multi select components to keep same styles.
PD:
I think we have a tech-debt here, where we should only have one Select element (instead of Select, MultiSelect and SearchableSelect, where we can make it multi or searchable through props). All of them with react-select. But this is something we can do afterwards

@balanza

balanza commented Apr 15, 2026

Copy link
Copy Markdown
Member

I think we have a tech-debt here, where we should only have one Select element (instead of Select, MultiSelect and SearchableSelect, where we can make it multi or searchable through props). All of them with react-select. But this is something we can do afterwards

I'd rather not add another component, in the end this one does the same thing as MultiSelect (which just wraps).

@antgamdia

Copy link
Copy Markdown
Contributor Author

Thanks for your early input here. Let's not create more components then 😅
Closing in favor of #4165 and the future work from @arbulu89

@antgamdia antgamdia closed this Apr 15, 2026
@antgamdia antgamdia deleted the TRNT-4339-1 branch April 15, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

3 participants