Always include src/scanner.c in Swift package sources#383
Open
iliaskarim wants to merge 1 commit into
Open
Conversation
SPM evaluates Package.swift with a cwd where FileManager.fileExists(atPath:) often misses src/scanner.c, so the scanner was dropped and consumers had to wrap the package. List parser.c and scanner.c explicitly. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/scanner.cwithFileManagerat manifest evaluation time.src/parser.candsrc/scanner.cin the Swift packagesources.Why
Under Xcode / SwiftPM,
Package.swiftis often evaluated with a working directory whereFileManager.default.fileExists(atPath: "src/scanner.c")returns false, so the external scanner is omitted and linking fails. Consumers work around this with local wrappers that hardcode both files. Listing the sources explicitly fixes the package for SPM clients.Test plan
swift build/ Xcode resolve includes scanner symbols fromsrc/scanner.cMade with Cursor