Repository navigation
fix(us): remove the contradictory SSP section count from us-fedramp-ssp - #763
Merged
Merged
Conversation
The command claimed a "15-section FedRAMP SSP structure" in two places while listing 16 numbered sections. Flagged during #754 and left unfixed through #755-#761. The count was not simply wrong. FedRAMP's published template nests Types of Users and Network Architecture beneath General System Description; this command flattens them out into a single numbered list, which is why the list runs longer than the template's top-level section count. So the prose was describing FedRAMP correctly and the list was describing something else, with nothing saying so. Rather than swap 15 for 16 — which would assert a count for FedRAMP's own template that this repo has no authoritative source for, and which the 2024 Rev 5 / OSCAL changes make a moving target — the fix removes the count from both places and explains the flattening instead. A reader who compares the list against the published Word template now knows why the numbering differs. Step 5 also now reads "Generate the following FedRAMP SSP sections:", matching the nine sibling us-* commands, which all use "Generate the following sections:". It was the only one asserting a count. No change to the 16 listed sections, and none needed to the FRSSP per-type checks: they were written against section names rather than a count, so they were already immune to this. Verified: 0 count claims remain, list still 16 items, guard reports 144 references across 12 plugins, registry gate and reference linter clean, converter regenerated, 1297 passed / 225 skipped, markdownlint clean. Refs #748 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VKbHCujejpxkgvh47BndDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
us-fedramp-ssp.mdclaimed a "15-section FedRAMP SSP structure" in two places while listing 16 numbered sections. I flagged this during #754 and it stayed unfixed through #755–#761; this clears it.The count wasn't simply wrong
FedRAMP's published template nests Types of Users and Network Architecture beneath General System Description. This command flattens them out into a single numbered list, which is exactly why the list runs longer than the template's top-level section count.
So the prose was describing FedRAMP correctly, the list was describing something else, and nothing said so. Reading it, you'd assume one of the two was a typo.
Why not just change 15 → 16
That would assert a top-level section count for FedRAMP's own template. This repo has no authoritative source for that number, and the 2024 Rev 5 and OSCAL submission changes make it a moving target — precisely the kind of claim that goes stale silently in a compliance tool.
Instead both count claims are removed and the flattening is explained. A reader comparing the list against the published Word template now knows why the numbering differs, which is more useful than either number would have been.
Consistency
Step 5 now reads
Generate the following FedRAMP SSP sections:, matching its nine siblingus-*commands, which all useGenerate the following sections:. It was the only one asserting a count at all.Scope
FRSSPper-type checks. They were written against section names rather than a count, so they were already immune to this. That was deliberate in feat(us): wire the 10 US federal doc-types into the quality checklist #754, and it held upVerification
check-quality-checklist-refs.py144 references / 12 plugins,check-doc-type-registry.py,check_references.py(836 files),sync-shared-assets.py --checkall cleanmarkdownlint-cli2clean🤖 Generated with Claude Code
https://claude.ai/code/session_01VKbHCujejpxkgvh47BndDE