fix: Bugbot findings from promotion PR #21#22
Open
shujaatTracebloc wants to merge 1 commit into
Open
Conversation
Bugbot (promotion PR #21), two findings: - Clone failure misreported as success: the model-zoo clone cell discarded stderr and ran an "already cloned" echo on ANY non-zero exit, so network/ permission/partial-clone failures looked like success. Guard on the directory actually existing; otherwise run git clone and let real errors surface. (notebooks/traceblocTrainingGuide.ipynb:107) - WIP check skips reopened PRs: wip-limit-check.yml listened only for opened/ ready_for_review, so reopened PRs re-entered active work without a WIP check, unlike the sibling kanban/status workflows. Add reopened. (.github/workflows/wip-limit-check.yml:5) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
aptracebloc
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the two Cursor Bugbot findings surfaced on the start-training promotion PR (#21, develop → main).
Fixes
2>/dev/null) and ranecho "model-zoo already cloned"on any non-zero exit, so network errors, permission problems, or a partial directory looked like success and later cells failed without a clear cause. Now it checks whether../model-zooactually exists; if not, it runsgit cloneand lets the real error surface. (chore(release): promote develop → main (week of 2026-06-29) #21 (comment))wip-limit-check.ymllistened only foropened/ready_for_review, so a reopened PR re-entered active work without a WIP-limit check, unlikeadd-to-kanban.yml/set-pr-status.yml. Addedreopened. (chore(release): promote develop → main (week of 2026-06-29) #21 (comment))Lands on
develop; the promotion PR head picks it up on the next sync and Bugbot re-reviews.🤖 Generated with Claude Code
Note
Low Risk
Small CI trigger alignment and a notebook shell one-liner; no auth, data, or production runtime paths.
Overview
Addresses two Bugbot findings from the develop→main promotion PR.
WIP limit on reopened PRs:
wip-limit-check.ymlnow runs onreopenedas well asopenedandready_for_review, matchingadd-to-kanban.ymlandset-pr-status.ymlso reopened PRs get a WIP check again.Training notebook model-zoo clone: The Option A cell no longer uses
git clone … 2>/dev/nullwith a fallback message that treated any failure like “already cloned.” It checks whether../model-zooexists first; only if missing does it rungit clone, so real clone errors surface instead of misleading success.Reviewed by Cursor Bugbot for commit 1421051. Bugbot is set up for automated code reviews on this repo. Configure here.