Merge develop into rename-clashing-and-non-snake-case-files#73
Closed
divyasinghds wants to merge 4 commits into
Closed
Merge develop into rename-clashing-and-non-snake-case-files#73divyasinghds wants to merge 4 commits into
divyasinghds wants to merge 4 commits into
Conversation
Filenames that shadowed the package they import from (e.g. catboost.py doing `from catboost import ...`) are renamed with a task suffix. Uppercase and hyphenated filenames are normalized to snake_case per the file naming convention in CLAUDE.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…d-non-snake-case-files
Bare `import torch` was unused in 26 PyTorch model files — only submodule imports like `import torch.nn as nn` or `from torch import ...` are needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…d-non-snake-case-files # Conflicts: # model_zoo/object_detection/pytorch/faster_rcnn_resnet.py
Contributor
|
👋 Heads-up — Code review queue is at 20 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin/developinto this branch to pick up the latest model additions and fixes.model_zoo/object_detection/pytorch/faster_rcnn_resnet.pyby dropping the unusedimport torch.nn as nn(consistent with the prior "remove unused torch imports" cleanup on this branch).Test plan
🤖 Generated with Claude Code
Note
Medium Risk
Adds many new model templates (some loading Hugging Face models with
trust_remote_code=True) and expands optional dependency skipping in contract tests, which could introduce runtime/import or supply-chain issues if used without the intended guards.Overview
Expands the model zoo with a large set of new templates across vision (classification/detection/segmentation/keypoints), text classification, tabular (including Mitra), time-series forecasting, and survival analysis, primarily via
timm,torchvision,transformers, andscikit-survival.Updates authoring guidance by recommending a
licensemetadata field and documenting federated-averaging-friendly modeling conventions, and adjusts the model contract test to treatinterpret,pytorch_forecasting, andpycoxas optional third-party dependencies (so CI can skip when they aren’t installed).Reviewed by Cursor Bugbot for commit 4d78183. Bugbot is set up for automated code reviews on this repo. Configure here.