ci: add concurrency cancellation + job timeouts to chart CI#265
Merged
Conversation
helm-ci.yaml and installer-tests.yaml are the repo's most expensive workflows (a real k3d cluster, a 9-distro docker-in-docker matrix, Windows Pester) but had no concurrency control, so a PR re-push left stale runs burning to completion. Add a per-ref concurrency group that cancels superseded PR runs only (push/schedule runs are never cancelled), matching the pattern already used in client-runtime's tests.yml. Add timeout-minutes to every job so a hung k3d/squid/distro step can't run to the 6h default. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
👋 Heads-up — Code review queue is at 31 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
saadqbal
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CI hygiene to the two most expensive workflows in the repo — both had no concurrency control or job timeouts.
concurrency(per-github.refgroup) onhelm-ci.yamlandinstaller-tests.yaml, cancelling superseded PR runs only. Push and schedule runs are never cancelled (cancel-in-progressgated ongithub.event_name == 'pull_request'). Mirrors the pattern already inclient-runtime'stests.yml.timeout-minuteson every job (10 for lint/static/unit, 20 for Pester/distro-prereqs, 30 for the real-k3d e2e jobs) so a hung cluster/squid/distro step can't run to the 6h default.Why these two:
helm-ci.yamlspins a real k3d cluster (upgrade-e2e) plus two 4-platform matrices;installer-tests.yamlruns a 9-distro docker-in-docker matrix + real-k3de2e-cluster+ Windows Pester. Withoutcancel-in-progress, every PR re-push left the previous full run burning to completion.Type
Test plan
yaml.safe_load); all 6 jobs in each now carrytimeout-minutes; top-levelconcurrencypresent.🤖 Generated with Claude Code