Conversation
After `helm upgrade --install` into the fixed `tracebloc` namespace, set the current kubeconfig context's namespace to it — so `kubectl` and the tracebloc CLI (`cluster info` / `dataset push`) default to the right namespace with no -n / --namespace flag. Without this the context stayed on `default`, so the first post-install CLI command errored: "no tracebloc parent client release found in namespace default". The documented next step (`tracebloc dataset push ./data`) hit it too. - Best-effort (`|| true`) so it never aborts an otherwise-successful install. - Honors TB_NAMESPACE overrides (uses the var, not a hardcoded name). - Mirrored in install-k8s.ps1. - New bats test asserts the set-context call with the namespace. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…-install fix(installer): point kubeconfig at the client namespace after deploy
aptracebloc
approved these changes
Jun 5, 2026
Contributor
|
👋 Heads-up — Code review queue is at 18 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related
Type of change
Test plan
Screenshots / recordings
Deployment notes
Checklist
Note
Low Risk
Installer-only, best-effort kubeconfig tweak with tests; no runtime auth or cluster logic changes.
Overview
After a successful Helm client install, both installers now run
kubectl config set-context --current --namespacefor the client namespace (defaulttracebloc, orTB_NAMESPACE). kubectl and the tracebloc CLI can use that namespace without-n/--namespace.The step is best-effort: on bash it uses
|| true; on Windows stderr is suppressed so a failed context update does not undo a successful install.A new BATS test asserts the bash path invokes
kubectl config set-context --current --namespace traceblocduringinstall_client_helm.Reviewed by Cursor Bugbot for commit 5f42156. Bugbot is set up for automated code reviews on this repo. Configure here.