Skip to content

Sync develop → main (CLI-in-installer + standard checks)#203

Merged
saadqbal merged 1 commit into
mainfrom
develop
Jun 4, 2026
Merged

Sync develop → main (CLI-in-installer + standard checks)#203
saadqbal merged 1 commit into
mainfrom
develop

Conversation

@saadqbal

@saadqbal saadqbal commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Brings main current with develop. Single delta since the last sync (#49): #202.

What this promotes (#202)

  • CLI install as Step 5 of both installers (install.sh / install.ps1) — runs the tracebloc CLI's own signed installer; non-fatal (guarded source/call so a stale bootstrap degrades gracefully instead of aborting under set -e).
  • New scripts/lib/install-cli.sh + bats/Pester coverage.
  • New scripts/lib/... wiring + .github/workflows/standard-checks.yml emitting Lint + Unit tests (the org-standard required contexts), so client PRs stop sitting at "Expected — waiting for status to be reported."

Why now (rollout ordering)

This puts scripts/lib/install-cli.sh on main, which the live tracebloc.io/i.sh fetches from. It must land here before the website i.sh deploy (tracebloc-website#357, already merged to website develop) reaches prod — otherwise the live bootstrap would 404 fetching a lib not yet on main.

No chart release/tag is cut here (chart releases go via tracebloc-v* tags separately).

🤖 Generated with Claude Code


Note

Medium Risk
Changes the post-connect installer path and pulls an external CLI installer at runtime, but Step 5 is explicitly non-fatal and stale-bootstrap guards limit breakage; CI additions are low risk.

Overview
Promotes develop → main with installer and CI updates so live bootstrap can fetch install-cli.sh from main before prod i.sh does.

Installer (Step 5): Both flows grow from four steps to five. After the client is connected, they install the official tracebloc CLI via github.com/tracebloc/cli release installers (bash: new scripts/lib/install-cli.sh; Windows: Install-TraceblocCli in a child PowerShell process). Failures warn only and never fail an otherwise successful install. Bash guards missing install-cli.sh / undefined install_tracebloc_cli so older bootstraps skip Step 5 instead of aborting under set -e. Bootstrap install.sh now downloads install-cli.sh. Roadmaps, step labels, and success summaries point users at tracebloc dataset push ./data.

CI: New .github/workflows/standard-checks.yml runs Lint (bash -n, ShellCheck) and Unit tests (bats) on every push/PR to protected branches—no path filters—so required branch-protection contexts always report.

Tests: bats for install_tracebloc_cli non-fatal behavior; Pester for Install-TraceblocCli.

Reviewed by Cursor Bugbot for commit dc287ca. Bugbot is set up for automated code reviews on this repo. Configure here.

feat(installer): install the tracebloc CLI as part of the client install (Step 5, both OSes)
@saadqbal saadqbal self-assigned this Jun 4, 2026
@LukasWodka

Copy link
Copy Markdown
Contributor

👋 Heads-up — Code review queue is at 15 / 8

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@saadqbal saadqbal merged commit c682395 into main Jun 4, 2026
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants