Conversation
feat(installer): install the tracebloc CLI as part of the client install (Step 5, both OSes)
Contributor
|
👋 Heads-up — Code review queue is at 15 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
shujaatTracebloc
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
maincurrent withdevelop. Single delta since the last sync (#49): #202.What this promotes (#202)
install.sh/install.ps1) — runs the tracebloc CLI's own signed installer; non-fatal (guardedsource/call so a stale bootstrap degrades gracefully instead of aborting underset -e).scripts/lib/install-cli.sh+ bats/Pester coverage.scripts/lib/...wiring +.github/workflows/standard-checks.ymlemittingLint+Unit tests(the org-standard required contexts), so client PRs stop sitting at "Expected — waiting for status to be reported."Why now (rollout ordering)
This puts
scripts/lib/install-cli.shonmain, which the livetracebloc.io/i.shfetches from. It must land here before the website i.sh deploy (tracebloc-website#357, already merged to websitedevelop) reaches prod — otherwise the live bootstrap would 404 fetching a lib not yet onmain.No chart release/tag is cut here (chart releases go via
tracebloc-v*tags separately).🤖 Generated with Claude Code
Note
Medium Risk
Changes the post-connect installer path and pulls an external CLI installer at runtime, but Step 5 is explicitly non-fatal and stale-bootstrap guards limit breakage; CI additions are low risk.
Overview
Promotes develop → main with installer and CI updates so live bootstrap can fetch
install-cli.shfrommainbefore prodi.shdoes.Installer (Step 5): Both flows grow from four steps to five. After the client is connected, they install the official tracebloc CLI via
github.com/tracebloc/clirelease installers (bash: newscripts/lib/install-cli.sh; Windows:Install-TraceblocCliin a child PowerShell process). Failures warn only and never fail an otherwise successful install. Bash guards missinginstall-cli.sh/ undefinedinstall_tracebloc_cliso older bootstraps skip Step 5 instead of aborting underset -e. Bootstrapinstall.shnow downloadsinstall-cli.sh. Roadmaps, step labels, and success summaries point users attracebloc dataset push ./data.CI: New
.github/workflows/standard-checks.ymlruns Lint (bash-n, ShellCheck) and Unit tests (bats) on every push/PR to protected branches—no path filters—so required branch-protection contexts always report.Tests: bats for
install_tracebloc_clinon-fatal behavior; Pester forInstall-TraceblocCli.Reviewed by Cursor Bugbot for commit dc287ca. Bugbot is set up for automated code reviews on this repo. Configure here.