Skip to content

fix(rbac): grant get on configmaps/secrets to jobs-manager SA #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shujaatTracebloc merged 1 commit into from
Jun 3, 2026
Merged

fix(rbac): grant get on configmaps/secrets to jobs-manager SA #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions client/templates/rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,12 @@ rules:
verbs: ["create"]
- apiGroups: [""]
resources: ["configmaps", "secrets"]
verbs: ["create"]
# `get` is required by jobs-manager's orphan-resource verify path
# (client-runtime#52) and the missing-row self-heal (client-runtime#54):
# on a create-409 it reads the existing ConfigMap/Secret to confirm the
# content matches before reusing it. Without `get`, those reads return
# Forbidden and the endpoint 500s instead of the intended 409/replay.
verbs: ["create", "get"]
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
Expand Down Expand Up @@ -95,7 +100,12 @@ rules:
# to authenticate ingestion calls — see the ClusterRole branch above.
- apiGroups: [""]
resources: ["configmaps", "secrets"]
verbs: ["create"]
# `get` is required by jobs-manager's orphan-resource verify path
# (client-runtime#52) and the missing-row self-heal (client-runtime#54):
# on a create-409 it reads the existing ConfigMap/Secret to confirm the
# content matches before reusing it. Without `get`, those reads return
# Forbidden and the endpoint 500s instead of the intended 409/replay.
verbs: ["create", "get"]
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
Expand Down
Loading