fix: default bare 64-hex account hashes to Basechain (0:) in detect_address - #90
Open
rylaix wants to merge 1 commit into
Open
fix: default bare 64-hex account hashes to Basechain (0:) in detect_address#90rylaix wants to merge 1 commit into
rylaix wants to merge 1 commit into
Conversation
When a bare 64-character hexadecimal account hash is passed to `detect_address`, it unconditionally prepended `-1:` (Masterchain) instead of the standard `0:` (Basechain) where the majority of accounts and contracts reside. This PR changes the default for bare 64-hex hashes to `0:`, while preserving explicit `-1:<hash>` and `0:<hash>` behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
detect_addressunconditionally defaults bare 64-character hexadecimal account hashes to Masterchain (-1:) instead of Basechain (0:).Problem
When a caller supplies a 64-character raw hex string (256-bit account ID) without a workchain prefix,
detect_addressprepended"-1:". Since the vast majority of user accounts, Jettons, and smart contracts reside on Basechain (0:), this caused downstream API callers and SDK consumers to resolve data from Masterchain for an intended Basechain account without any warning.Solution
detect_addressinpytonlib/utils/address.pyto default bare hexadecimal hashes to"0:"."-1:<hash>"and"0:<hash>"address formats.Reproduction / Test