Repository navigation
Fix custom GitLab URL ignored due to wrong key in CI values files - #15
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…in CI values files The CI values files used flat key `gitlab_url` instead of the nested `gitlab.url` expected by the application config and values.yaml. Helm deep-merge kept the default https://gitlab.com since the override targeted a different key. - Fix all ci/*.yaml files to use `exporterConfig.gitlab.url` (nested) - Update configmap_test.yaml pattern and add negative assertion - Fix helm-chart.yml lint step to use correct `--set` key - Add GitLab URL validation step to template-test job Co-authored-by: tomer1983 <22876011+tomer1983@users.noreply.github.com>
tomer1983
marked this pull request as ready for review
February 26, 2026 06:32
Copilot
AI
changed the title
[WIP] Fix GitLab URL setting in helm chart
Fix custom GitLab URL ignored due to wrong key in CI values files
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All CI values files used the flat key
exporterConfig.gitlab_urlwhilevalues.yamland the application config both use the nested keyexporterConfig.gitlab.url. Helm's deep merge treated these as separate keys, leaving the defaulthttps://gitlab.compermanently in effect regardless of what was specified.Root cause
Changes
ci/*.yaml— Replace flatgitlab_url: "..."with the correct nestedgitlab:\n url: "..."structure in all five CI values filestests/configmap_test.yaml— Update assertion pattern to matchurl:inside thegitlab:block; add negative assertion that the defaultgitlab.comURL is absent when a custom URL is set.github/workflows/helm-chart.yml--setflag:exporterConfig.gitlab_url→exporterConfig.gitlab.urltemplate-testjob that parses the rendered ConfigMap and fails if the URL is still the hardcoded defaultOriginal prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.