Skip to content

Fix custom GitLab URL ignored due to wrong key in CI values files - #15

Merged
tomer1983 merged 2 commits into
mainfrom
copilot/fix-gitlab-url-setting
Feb 26, 2026
Merged

tomer1983 merged 2 commits into
mainfrom
copilot/fix-gitlab-url-setting

Conversation

Copilot AI commented Feb 26, 2026 •

Copy link
Copy Markdown
Contributor

All CI values files used the flat key exporterConfig.gitlab_url while values.yaml and the application config both use the nested key exporterConfig.gitlab.url. Helm's deep merge treated these as separate keys, leaving the default https://gitlab.com permanently in effect regardless of what was specified.

Root cause

# values.yaml (correct — what the app reads)
exporterConfig:
  gitlab:
    url: "https://gitlab.com"

# ci/*-values.yaml (wrong — different key, never overrides the above)
exporterConfig:
  gitlab_url: "https://gitlab.example.com"

Changes

  • ci/*.yaml — Replace flat gitlab_url: "..." with the correct nested gitlab:\n url: "..." structure in all five CI values files
  • tests/configmap_test.yaml — Update assertion pattern to match url: inside the gitlab: block; add negative assertion that the default gitlab.com URL is absent when a custom URL is set
  • .github/workflows/helm-chart.yml
    • Fix lint step --set flag: exporterConfig.gitlab_url → exporterConfig.gitlab.url
    • Add a Validate GitLab URL is set from values step to the template-test job that parses the rendered ConfigMap and fails if the URL is still the hardcoded default
Original prompt

The current issue is that the GitLab URL remains set to gitlab.com even when a custom GitLab URL is specified in the values.yaml file. This could be due to an issue with how the chart processes the values.yaml file, or how the GitLab URL is being overwritten or ignored.

Task:

  • Analyze the helm chart to understand how the GitLab URL is being set.
  • Check for any placeholders, environment variables, or defaults that override the value set in values.yaml.
  • Investigate if there are scripts or deployment files that hardcode gitlab.com, bypassing the provided values.yaml.
  • Create validation tests within the GitHub Actions workflow to catch this issue in future updates.
  • Confirm that the value set in values.yaml properly configures the GitLab URL.

Deliverables:

  • A fix to ensure that the custom GitLab URL from values.yaml is respected when deploying the chart.
  • Addition of validation tests to the GitHub Actions workflow to ensure this functionality is checked in pipeline runs.

This pull request was created from Copilot chat.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…in CI values files

The CI values files used flat key `gitlab_url` instead of the nested
`gitlab.url` expected by the application config and values.yaml.
Helm deep-merge kept the default https://gitlab.com since the override
targeted a different key.

- Fix all ci/*.yaml files to use `exporterConfig.gitlab.url` (nested)
- Update configmap_test.yaml pattern and add negative assertion
- Fix helm-chart.yml lint step to use correct `--set` key
- Add GitLab URL validation step to template-test job

Co-authored-by: tomer1983 <22876011+tomer1983@users.noreply.github.com>
@tomer1983
tomer1983 marked this pull request as ready for review February 26, 2026 06:32
Copilot AI changed the title [WIP] Fix GitLab URL setting in helm chart Fix custom GitLab URL ignored due to wrong key in CI values files Feb 26, 2026
@tomer1983
tomer1983 merged commit 6c6eaeb into main Feb 26, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants