Add support for wait/until functions with updated example code#20
Add support for wait/until functions with updated example code#20agilecreativity wants to merge 7 commits into
Conversation
- Make it possible to wait for some event to happen before acting on it - Much more efficient than using wait/sleep
|
@tmarble it would be great if we could setup the CI/CD using something like CircleCI or TravisCI? |
|
@agilecreativity I really appreciate you working on this! I'm in the middle of making sure we can close #12 and I realized that webica got into a non-functional state. So yes, absolutely, I'd like to add TravisCI support (ideally with sauce labs too). I'm going to ask for your patience as I finish my PR for#12 and then we can look at this PR and rebase/adjust as required. I'm looking at trying to coerce a vector of strings into a In your changes is the notion of the 10 second timeout preserved in the |
|
I think the timeout can be now set to the preferred time using the code here: https://github.com/agilecreativity/webica/blob/master/src/webica/web_driver_wait.clj#L27-L40 Which can be override if desired. The reference Java api is here: |
|
@tmarble |
@tmarble
As I promised,
This PR is the improved version of wait/until function that I submitted earlier.
What has changes:
Please let me know if you like any adjustment or if you have any comments.
Cheers,
Burin