perf: reduce memory usage - #128
Merged
Merged
Conversation
daubners
force-pushed
the
memory_optimisation
branch
from
July 29, 2026 16:19
590b6f0 to
149e41f
Compare
Contributor
Author
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces GPU memory use across TauFactor solvers while preserving benchmarked tortuosity values and convergence iteration counts.
uint8; uses boolean checkerboards/masks.repeat()allocations.VRAM_I_max,VRAM_I_cur,VRAM_S_max, andVRAM_S_cur.NVIDIA RTX A6000 benchmark
Compared fcc structure runs up to 1024³ for current main versus this code, using
VRAM(max)and solver wall time :Before these changes, initialization was particularly limiting for periodic solvers: periodic electrode initialization peaked at 424 MB versus 338 MB for the non-periodic version. Direct periodic neighbour sums remove that rolling-allocation bottleneck; both now peak at 287 MB during initialization. Overall peak memory is now determined by the solve phase rather than construction.
Validation
tauvalues and iteration counts are unchanged in the compared runs.