Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Don't touch native projects. - #95

Open
merqlove wants to merge 1 commit into
tildeio:masterfrom
merqlove:safe-check
Open

Don't touch native projects.#95
merqlove wants to merge 1 commit into
tildeio:masterfrom
merqlove:safe-check

Conversation

@merqlove

Copy link
Copy Markdown

Here was a trouble with false positive checking for library binaries, even if we have binary projects (CLI and so on). So i think better don't touch projects without Gemfile inside.

@wagenet

wagenet commented May 15, 2017

Copy link
Copy Markdown
Collaborator

@merqlove can you give me a more specific example of the scenario in which this was an issue?

@merqlove

merqlove commented May 15, 2017 via email

Copy link
Copy Markdown
Author

@merqlove

Copy link
Copy Markdown
Author

Simple example of such structure:

screenshot 2017-05-15 23 04 24

@merqlove

Copy link
Copy Markdown
Author

Hi, @wagenet you understood that problem?

@merqlove

Copy link
Copy Markdown
Author

Also, here can be optional setup ability for binary-only projects, i mean ability to enable/disable Helix functions: copy library, check state or change copy/destination path.
Currently here is a always error on sp_cli native library copy action, if helix without such changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants