migrate from paste to preinterpret - #130
Open
BenjaminBrienen wants to merge 1 commit into
Open
Conversation
|
Welcome @BenjaminBrienen! It looks like this is your first PR to tikv/jemallocator 🎉 |
Signed-off-by: BenjaminBrienen <Benjamin.Brienen@outlook.com>
BenjaminBrienen
force-pushed
the
preinterpret
branch
from
June 23, 2025 00:37
ab1a651 to
82e6387
Compare
Author
|
Hello? |
|
It's sad when there is not even an AI reviewer to merge valuable contributions faster, instead of waiting years for a first review 😞 |
Member
|
#129 was discussed in #123. I don't think it's appropriate to migrate a mature library to another that is not commonly used and not yet earned trust. I don't think the unmaintained status is a real problem, however, if you like, I also accept a patch that remove the paste dependency by rewriting the generation code path without paste and any third-party lib. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129