Create the directory for a custom types path if it doesn't exist#888
Merged
Merged
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a custom path is passed to
--types, the declaration file is written without first ensuring its parent directory exists. Runningziggy:generatewith a custom types path therefore fails if that directory isn't already there:php artisan ziggy:generate --types-only --types=tmp/ziggy/nested/ziggy.d.ts # file_put_contents(.../tmp/ziggy/nested/ziggy.d.ts): Failed to open stream: No such file or directoryCommandRouteGeneratoralready callsensureDirectoryExists()for the main output path, but not for the custom types path that's written later. This adds the same call before writing the types file, so its directory is created when needed, just like for the main output.Closes #883.