Add support for C5.0 decision tree models#245
Merged
Conversation
partykit's split varid indexes the columns of model$data, not the terms list. These coincide for ctree (response first) but not for parties converted from other models, where the mapping mislabeled every split.
Parse the tree structure C5.0 stores as text, rather than converting via partykit::as.party(), which needs the training data unavailable in x/y fits. Boosted and rule-based models are rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tidypredict support for
C50::C5.0()classification trees, includingdecision_tree()parsnip models fitted with the"C5.0"engine. The parser reads the tree structure C5.0 serializes as text rather than converting throughpartykit::as.party(), since that conversion re-evaluates the fitting call to recover the training data, which is unavailable when the model is fit through the x/y interface (as parsnip does). Boosted (trials > 1) and rule-based (rules = TRUE) models are not representable as a single tree and raise an error.Relates to #232; the
decision_tree()/C5.0 checkbox can be checked there.