Implement template-fitting class#267
Open
torresramiro350 wants to merge 83 commits into
Open
Conversation
…threeML-master
only when the evaluate method is called by threeML
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #267 +/- ##
==========================================
+ Coverage 79.79% 80.17% +0.37%
==========================================
Files 47 48 +1
Lines 5958 6314 +356
==========================================
+ Hits 4754 5062 +308
- Misses 1204 1252 +48 🚀 New features to boost your workflow:
|
Contributor
|
That's really cool @torresramiro350! Can you change the target branch of the PR to |
Author
|
@PreisTo Hi, sure, I've switched the target branch to be |
PreisTo
requested changes
Apr 27, 2026
PreisTo
left a comment
PreisTo
left a comment
Contributor
There was a problem hiding this comment.
Nice work :)
Maybe you can recycle some of the functions and classes you redefine from template_model.py. Would make it more easier to maintain in the long run
I also added an attribute that differentiates between the two template models. This should be a cleaner approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
spatial_model.pythat implements a 3D template-fitting class, which adoptsTemplateModelmodule andGalprop. This module was used in the paper: A. Albert et al (HAWC Collaboration) 2024.A unit test is included in
test_3D_template.py