docs: correct ADR-0002 post-merge review findings

[ja573]

Summary

Resolves the three P1 findings raised by the automated Codex review after PR #769 merged:

• embed complete exact proposed issue bodies for Publisher Services: packages, distribution configuration and controlled rollout #765 and Thoth Metrics: canonical ingestion, Sphinx orchestration and client cutover #766 in the ADR-0002 approval report;
• reconcile the active agent-instruction rollout plan with the engineering README;
• remove trailing whitespace and verify the documentation gate accurately.

Documentation and control evidence only. No ADR, runtime, migration, API, workflow, deployment or issue write.

Task specification: docs/engineering/ai-delivery/tasks/ADR-0002-POST-MERGE-CORRECTION.md

Invariants

• ADR-0001 remains PROPOSED
• ADR-0002 remains APPROVED
• Publisher Services ADR-01 and final inventory remain unapproved
• MET-CTRL-01 remains CHANGES REQUIRED
• all implementation work remains BLOCKED
• issues Publisher Services: packages, distribution configuration and controlled rollout #765 and Thoth Metrics: canonical ingestion, Sphinx orchestration and client cutover #766 are not edited
• no runtime effect

Draft until fresh independent review returns APPROVED.

[ja573]

Final implementation evidence — ADR-0002-POST-MERGE-CORRECTION

Final exact head: ca8e90645957c50c25fecd8b220772837bb522d3

Correction commit: ca8e90645957c50c25fecd8b220772837bb522d3
Base: e124221f8444bd738228f1b609c536639be8789e
Prior reviewed evidence head: 8158603b30e87074326b5729bcf661678a4dccd5

Fresh exact-head workflow runs:

• 30350291988 — build-test-and-check: success
  • build: success
  • test: success
  • lint: success
  • format_check: success
• 30350292026 — run-migrations: success
  • run_migrations: success
• 30350291967 — check-changelog: success
  • check-changelog: success
• 30350291964 — publish-to-dockerhub: success
  • build_and_push_staging_docker_image: success

git diff --check e124221f8444bd738228f1b609c536639be8789e...ca8e90645957c50c25fecd8b220772837bb522d3: exit 0, no output.

Cumulative diff remains exactly four files. The rollout-plan cumulative diff contains only the intended thoth current-state row and rollout-sequence item 1 replacements; all unrelated control content is restored from the base.

Issue #765: unchanged — OPEN, updatedAt: 2026-07-27T15:50:33Z, baseline body sha256 96c31089a3046eadf51a0fc39b12d0275ce26f4d752c64282f5dcb933f78ca15.

Issue #766: unchanged — OPEN, updatedAt: 2026-07-24T17:17:11Z, baseline body sha256 6b1bb092f3f0b436c01faaabbf4fb5df331268f4d687463b3c715fb4ea9d6dbc.

PR #770 remains draft. PR #769 review threads remain unresolved. No issue write, deployment, release or production activation occurred.

Ready for fresh independent review; this comment does not mark the PR ready or approve it.

[ja573]

Independent review - APPROVED

Reviewed head: ca8e90645957c50c25fecd8b220772837bb522d3

Independence attestation: Fresh non-implementing reviewer; review remained read-only. No branch, PR, issue, thread or repository state was modified.

Decision: APPROVED

Findings:

• P0: none
• P1: none
• P2: none

Verified:

• exact four-file cumulative diff;
• rollout-plan diff limited to the two intended one-line replacements;
• unrelated rollout controls fully restored;
• complete corrective implementation evidence;
• exact issue baseline and proposed-body hashes;
• clean git diff --check;
• all seven required exact-head CI jobs successful;
• no runtime, migration, authorization, deployment or issue-write effects;
• ADR-0001 remains PROPOSED;
• ADR-0002 remains APPROVED;
• Publisher Services ADR-01 and the final enum remain unapproved;
• MET-CTRL-01 remains CHANGES REQUIRED;
• Publisher Services implementation tasks and Metrics work packages remain BLOCKED.

Merge recommendation: approval gate satisfied. Merge remains subject to explicit CTO authorization.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca8e906459

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[ja573]

Previous approval superseded

The independent APPROVED decision recorded for
ca8e90645957c50c25fecd8b220772837bb522d3 does not apply to the new
correction head.

PR #770 remains draft and unmerged. Fresh independent review is required at
the new exact head before it may be marked ready or merged.

[ja573]

Decision: APPROVED

Reviewed head: cb82ce799ca3afecf8f243faa7ebb9d10c5d049b

Independence attestation: Fresh exact-head, non-implementing, read-only review. I did not modify the branch, pull request, issues, review threads, repository files, CI state, deployment state, or production state.

P0 findings: None.

P1 findings: None.

P2 findings: None.

Changed-file assessment: The cumulative diff contains exactly the five approved files:

CHANGELOG.md
docs/engineering/agent-instructions/rollout-plan.md
docs/engineering/ai-delivery/implementation-reports/ADR-0002-APPROVE-implementation-report.md
docs/engineering/ai-delivery/implementation-reports/ADR-0002-POST-MERGE-CORRECTION-implementation-report.md
docs/engineering/ai-delivery/tasks/ADR-0002-POST-MERGE-CORRECTION.md

The correction from ca8e90645957c50c25fecd8b220772837bb522d3 to the reviewed head is one commit changing exactly:

CHANGELOG.md
docs/engineering/ai-delivery/implementation-reports/ADR-0002-POST-MERGE-CORRECTION-implementation-report.md
docs/engineering/ai-delivery/tasks/ADR-0002-POST-MERGE-CORRECTION.md

No ADR, application source, SQL, migration, GraphQL, workflow, generated-code, deployment, authorization, security, or repository-protection file changed.

Task-specification assessment: Passed. The specification now contains explicit Dependencies, Required tests, Migration effect, and Stop conditions. It records the CTO-approved changelog scope amendment, supersedes the earlier no-changelog amendment without erasing its history, expands the allowlist to include CHANGELOG.md, and preserves the approved task identity, objective, non-goals, invariants, acceptance criteria, rollout, and rollback.

Changelog assessment: Passed. CHANGELOG.md contains exactly one PR #770 entry under ## [Unreleased] / ### Changed, positioned above PR #769. The no changelog label is absent, and the changelog workflow succeeded using the actual entry.

Rollout-plan assessment: Passed. The cumulative rollout-plan diff remains limited to exactly two one-line replacements:

• the thoth current-state row;
• rollout-sequence item 1.

The stop conditions bullet, Delivery model, Source authority, and all unrelated controls remain unchanged from base.

Implementation-evidence assessment: Passed. The report records the post-ready automated review at 2026-07-28T12:06:55Z, correctly classifies its two valid findings and one incorrect merged-state premise, records the expanded five-file boundary, preserves the issue evidence and proposed-body hashes, states that PR #770 remains draft and unmerged, and does not fabricate a merge commit, merge timestamp, merge actor, branch deletion, or post-merge PR #769 thread state.

Review-thread assessment: Passed. All three post-ready PR #770 threads received responses tied to correction commit cb82ce799ca3afecf8f243faa7ebb9d10c5d049b and are resolved:

PRRT_kwDODkn0bc6UZAcG: resolved
PRRT_kwDODkn0bc6UZAcH: resolved
PRRT_kwDODkn0bc6UZAcI: resolved

The earlier approval at ca8e90645957c50c25fecd8b220772837bb522d3 is correctly recorded as superseded.

Issue-body and hash assessment: Passed. Issues #765 and #766 remain open with the reviewed live bodies and timestamps:

#765 updatedAt:
2026-07-27T15:50:33Z

#765 baseline sha256:
96c31089a3046eadf51a0fc39b12d0275ce26f4d752c64282f5dcb933f78ca15

#765 proposed sha256:
da12243b2a1898fd3fd574aada1dede3296ff13f38943e4fbb78a3dcb5ae1a35

#766 updatedAt:
2026-07-24T17:17:11Z

#766 baseline sha256:
6b1bb092f3f0b436c01faaabbf4fb5df331268f4d687463b3c715fb4ea9d6dbc

#766 proposed sha256:
f4e8aa7e855b2b3c44b4cf38c60475861079698cc7f5cd95a6ac319b892cb772

Neither issue was written. The proposed bodies remain evidence only and do not authorize synchronization.

Whitespace assessment: Passed. The recorded cumulative git diff --check result is exit 0 with no output. No whitespace, conflict-marker, or documentation-boundary problem is evident in the reviewed diff.

Exact-head CI assessment: Passed. These runs target cb82ce799ca3afecf8f243faa7ebb9d10c5d049b and all seven jobs concluded success:

30361722071 - build-test-and-check
  build: success
  test: success
  lint: success
  format_check: success

30361722168 - run-migrations
  run_migrations: success

30361722363 - check-changelog
  check-changelog: success

30361721929 - publish-to-dockerhub
  build_and_push_staging_docker_image: success

Runtime/migration/authorization assessment: None. This remains documentation and engineering-control reconciliation only. No runtime, migration, API, authorization, deployment, release, or production behaviour changed.

Control-state assessment: Passed.

ADR-0001: PROPOSED
ADR-0002: APPROVED
Publisher Services ADR-01: unapproved
Platform inventory: FINAL ENUM NOT APPROVED
MET-CTRL-01: CHANGES REQUIRED
All Publisher Services implementation tasks: BLOCKED
All Metrics work packages: BLOCKED
Issues #765 and #766: unchanged
PR #769 threads: unresolved pending authorized post-merge closeout

Merge recommendation: The fresh independent-review gate is satisfied at exact head cb82ce799ca3afecf8f243faa7ebb9d10c5d049b.

PR #770 may be marked ready and merged only under the existing explicit CTO merge authorization, after confirming immediately before merge that:

• the head remains exactly cb82ce799ca3afecf8f243faa7ebb9d10c5d049b;
• develop remains exactly e124221f8444bd738228f1b609c536639be8789e;
• all seven checks remain successful;
• no new unresolved P0 or P1 finding appears after the ready transition.

Do not edit issues #765/#766 or resolve PR #769 threads until PR #770 has merged and the merge commit is verified on develop.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb82ce799c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[ja573]

Previous approval superseded

The independent APPROVED decision recorded for
cb82ce799ca3afecf8f243faa7ebb9d10c5d049b is superseded by the subsequent
post-ready P1 findings.

PR #770 is draft and unmerged. Fresh exact-head CI and a fresh independent review
are required before it may be marked ready or merged.

[ja573]

Independent exact-head review: APPROVED

Reviewed head: 5252faf105f2156193c109f40e9c9eb6adf15cba

Independent reviewer/model: ChatGPT / GPT-5.6 Thinking
Review context: fresh, non-implementing, and read-only

• P0 findings: none
• P1 findings: none
• P2 findings: none
• Changed-file scope: exactly the five approved documentation/control files
• Runtime, migration, schema, API, generated-code, authorization, deployment, and production effects: none
• All PR docs: correct ADR-0002 post-merge review findings #770 review threads: resolved
• PR docs: record CTO approval of ADR-0002 platform domain boundaries #769's three residual corrective threads: intentionally unresolved pending separately authorized post-merge closeout
• Issues Publisher Services: packages, distribution configuration and controlled rollout #765 and Thoth Metrics: canonical ingestion, Sphinx orchestration and client cutover #766: open and unchanged
• No task or work package becomes READY

Exact-head CI

All seven jobs completed successfully for 5252faf105f2156193c109f40e9c9eb6adf15cba:

• 30366300164 — build-test-and-check
  • build: success
  • test: success
  • lint: success
  • format_check: success
• 30366299295 — run-migrations
  • run_migrations: success
• 30366299428 — check-changelog
  • check-changelog: success
• 30366299812 — publish-to-dockerhub
  • build_and_push_staging_docker_image: success

The independent-review gate is satisfied at this exact head. The PR remains gated on explicit CTO merge authorization for 5252faf105f2156193c109f40e9c9eb6adf15cba; earlier authorization applied to a superseded head, and later corrective approvals expressly excluded merge. After that authorization, re-confirm the unchanged head/base/checks, mark the PR ready, allow the automated post-ready review to complete, and merge only if no new unresolved P0/P1 finding appears.

[ja573]

Javi, CTO, authorizes PR #770 to be marked ready for review and, subject to the conditions below, merged using a merge commit at exact head:

5252faf105f2156193c109f40e9c9eb6adf15cba

against exact base:

e124221f8444bd738228f1b609c536639be8789e

This authorization is valid only if:

• the head and base remain unchanged;
• all seven required CI jobs remain successful;
• the automated review triggered by marking the PR ready has completed;
• no new unresolved P0 or P1 finding exists;
• PR docs: correct ADR-0002 post-merge review findings #770 remains mergeable;
• the recorded independent approval remains applicable to the exact head.

An administrator override is authorized only if the sole remaining blocker is GitHub's formal approval requirement caused by the authenticated account being unable to submit the independent review formally. It must not override changed code, failed or pending CI, merge conflicts, review findings, or branch-protection security controls.

After the merge is verified on develop, this authorization also permits:

• deleting the merged task branch;
• replying to the three existing PR docs: record CTO approval of ADR-0002 platform domain boundaries #769 corrective review threads with the verified PR docs: correct ADR-0002 post-merge review findings #770 merge commit;
• resolving only those three threads;
• posting the final PR docs: correct ADR-0002 post-merge review findings #770 closeout comment.

This authorization does not permit:

• editing issues Publisher Services: packages, distribution configuration and controlled rollout #765 or Thoth Metrics: canonical ingestion, Sphinx orchestration and client cutover #766;
• applying either proposed issue synchronization;
• changing repository files or creating another commit;
• deploying, releasing, or activating production behaviour;
• modifying branch protection;
• starting CI-DOCS-01 before the merge and post-merge closeout are verified.

Stop without merging if any authorized condition is no longer satisfied.

[ja573]

Final post-merge closeout

PR #770 is merged and the authorized closeout is complete.

Merge record

• Authorized head: 5252faf105f2156193c109f40e9c9eb6adf15cba
• Authorized base: e124221f8444bd738228f1b609c536639be8789e
• Verified merge commit: 0af9fbae940464a8f94aa1d9a857bad7a55ac54c
• Merged at: 2026-07-28T15:04:18Z
• Merge method: merge commit
• Live develop tip after merge: 0af9fbae940464a8f94aa1d9a857bad7a55ac54c
• Merge parents: authorized base and authorized head

The administrator override was used solely for GitHub's one-formal-approval requirement. Immediately before merge, the PR was mergeable, all seven required jobs were completed and successful, no unresolved review thread existed, head/base were unchanged, and the post-ready Codex automation had completed cleanly with its documented +1 signal at 2026-07-28T14:47:52Z after the ready event at 2026-07-28T14:44:13Z.

Post-merge closeout

• Deleted feature/engineering/adr-0002-post-merge-correction locally and remotely.
• Replied to and resolved exactly the three PR docs: record CTO approval of ADR-0002 platform domain boundaries #769 corrective threads:
  • PRRT_kwDODkn0bc6UWXT- — exact proposed issue bodies
  • PRRT_kwDODkn0bc6UWXUL — rollout-plan reconciliation
  • PRRT_kwDODkn0bc6UWXUP — documentation whitespace gate
• PR docs: record CTO approval of ADR-0002 platform domain boundaries #769 unresolved review-thread count: 0
• PR docs: correct ADR-0002 post-merge review findings #770 unresolved review-thread count: 0

Preserved controls

• Issue Publisher Services: packages, distribution configuration and controlled rollout #765 remains open, updatedAt: 2026-07-27T15:50:33Z, baseline SHA-256 96c31089a3046eadf51a0fc39b12d0275ce26f4d752c64282f5dcb933f78ca15.
• Issue Thoth Metrics: canonical ingestion, Sphinx orchestration and client cutover #766 remains open, updatedAt: 2026-07-24T17:17:11Z, baseline SHA-256 6b1bb092f3f0b436c01faaabbf4fb5df331268f4d687463b3c715fb4ea9d6dbc.
• Neither proposed issue synchronization was applied.
• No additional repository change or commit was created.
• No deployment, release, production activation, branch-protection change, or CI-DOCS-01 work occurred.
• No task or work package becomes READY as a result of this closeout.