Repository navigation
fix(codegen): keep deprecated fields required in split response types - #225
Merged
Merged
Conversation
A type whose request and response shapes differ is split into input::X and output::X. The output copy is still a type used in requests, and clients send back what they read, so relaxing its deprecated fields broke code passing an output value where the input type is expected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7zEtTUpmxtYWDkuq6uwpY
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
📖 Documentation Preview: https://reflectapi-docs-preview-pr-225.partly.workers.dev Updated automatically from commit 58cbd62 |
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#218 relaxes deprecated fields of response-only types, and keeps them required in types also used in requests. A type whose request and response shapes differ is split by consolidation into
a::input::Xanda::output::X, and theoutputcopy counted as response-only. It is still a type used in requests, though. Clients often read a value and send it back, and in TypeScript anoutput::Xpassed whereinput::Xis expected stopped type-checking, because the deprecated field was?:in one and required in the other. A large API built against 0.24.0-alpha.2 hit this when copying a business rule's schema from a read into an insert.The transform now skips an
outputcopy whoseinputtwin is in the request types. It finds the twin by the namingconsolidate_typesuses. Anoutputmodule without a twin is still an ordinary response type.In the same API, all five other relaxed fields are on response-only types, so they stay relaxed.
The
reflectapi_deprecation_datessnapshots go back to required fields, because that fixture's types are bothInputandOutput. The field-presenceProfilefixture still covers relaxing in all four generators.Testing: new unit test
the_response_copy_of_a_split_type_keeps_deprecated_fields, the full workspace tests, the field-presence suites (Rust, TypeScript and Python) and the Python demo regen with no drift.🤖 Generated with Claude Code
https://claude.ai/code/session_01Q7zEtTUpmxtYWDkuq6uwpY