fix: order Promise.any() rejection reasons by input index#183
Open
deepview-autofix wants to merge 1 commit into
Open
fix: order Promise.any() rejection reasons by input index#183deepview-autofix wants to merge 1 commit into
deepview-autofix wants to merge 1 commit into
Conversation
Promise.any() collected rejection reasons using push(), which stored them in completion order rather than input index order. The ES2021 spec requires AggregateError.errors to be ordered by the input promise index. Use index-based assignment and a separate counter instead, matching the approach used by Promise.all(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
|
There is no change log for this pull request yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promise.any() collected rejection reasons using push(), which stored them in completion order rather than input index order. The ES2021 spec requires AggregateError.errors to be ordered by the input promise index. Use index-based assignment and a separate counter instead, matching the approach used by Promise.all().
Fixes: #181