feat: add AutoCat settings and CategoryTabsManager

.gemini_security/DRAFT_SECURITY_REPORT.md

@@ -0,0 +1,32 @@
+Vulnerability: SQL Injection
+Severity: Medium
+Location: /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/AppDatabase.kt (lines 20-22)
+Line Content:
+suspend fun checkpoint() {
+    iconOverrideDao().checkpoint(SimpleSQLiteQuery("pragma wal_checkpoint(full)"))
+    wallpaperDao().checkpoint(SimpleSQLiteQuery("pragma wal_checkpoint(full)"))
+    folderDao().checkpoint(SimpleSQLiteQuery("pragma wal_checkpoint(full)"))
+}
+Description: The `checkpoint()` method, and by extension the `iconOverrideDao().checkpoint()`, `wallpaperDao().checkpoint()`, and `folderDao().checkpoint()` methods, accept a `SimpleSQLiteQuery` object. While the current usage hardcodes a safe SQL string ("pragma wal_checkpoint(full)"), this pattern can be problematic if `SimpleSQLiteQuery` is instantiated with a string that is constructed, even partially, from untrusted input. This could allow for SQL injection, where an attacker manipulates the SQL query to execute arbitrary database commands, potentially leading to data exfiltration, modification, or deletion.
+Recommendation:
+1.  **Prefer Parameterized Queries:** Always use parameterized queries (e.g., Room's `@Query` with parameters or `RoomDatabase.query` with `CancellationSignal` and `bindStatement`) instead of raw SQL strings that could be concatenated with untrusted input.
+2.  **Strict Input Validation:** If raw SQL strings must be used, ensure all components of the string are rigorously validated and sanitized to prevent injection attacks.
+3.  **Audit `checkpoint` usages:** Audit all usages of `checkpoint` functions in `IconOverrideDao`, `WallpaperDao`, and `FolderDao` to ensure that `SimpleSQLiteQuery` is never constructed from untrusted input.
+
+Vulnerability: Insecure Data Storage
+Severity: Medium
+Location: /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/AppDatabase.kt (lines 57-58)
+Line Content:
+database.execSQL("ALTER TABLE Folders ADD COLUMN icon TEXT DEFAULT NULL")
+Description: The `Folders` table schema is altered in `MIGRATION_3_4` to include an `icon TEXT DEFAULT NULL` column. If this `icon` field is later populated with untrusted input (e.g., user-provided paths, external data) without proper validation, it could become a vector for path traversal attacks or lead to insecure data access if the paths are used to read/write files. Additionally, storing arbitrary text without length limits can lead to database bloat, impacting performance and storage, and potentially a denial-of-service if an attacker can inject excessively long strings.
+Recommendation:
+1.  **Strict Path Validation:** Whenever data is written to the `icon` column, ensure that it is a valid, safe URI or canonicalized path. Implement strict whitelisting for allowed schemes, hosts, and paths. Prevent any path traversal sequences (e.g., `../`).
+2.  **Length Constraints:** Enforce reasonable length constraints on the `icon` field to prevent excessive data storage and potential denial-of-service.
+
+Vulnerability: Temporary `allowMainThreadQueries()`
+Severity: Low (Informational)
+Location: /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/AppDatabase.kt (line 74)
+Line Content:
+.allowMainThreadQueries() // Temporary fix to prevent startup crashes
+Description: The database builder uses `allowMainThreadQueries()`, enabling database operations on the main thread. While noted as a temporary fix for startup crashes, performing blocking I/O operations on the main thread can lead to Application Not Responding (ANR) errors, causing a poor user experience. While not a direct security vulnerability in terms of data compromise, a persistent ANR could be leveraged by an attacker to degrade user experience or make the device unresponsive (a form of Denial of Service), especially if an attacker can trigger a long-running query on the main thread.
+Recommendation: Remove `allowMainThreadQueries()` and ensure all database operations are performed on a background thread (e.g., using Kotlin Coroutines with `Dispatchers.IO`) to maintain UI responsiveness and prevent ANRs. This is a best practice for Android development.

.gemini_security/SECURITY_ANALYSIS_TODO.md

@@ -0,0 +1,70 @@
+- [x] Define the audit scope.
+- [ ] Conduct a two-pass SAST analysis on all files within scope.
+  - [x] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/AutoCatAppProvider.kt
+    - [x] Investigate data flow from `jsonStr` on line 58 in `loadSubCategoryIcons()`.
+    - [x] Investigate data flow from `iconPath` on line 74 in `saveSubCategoryIcon()`.
+    - [x] Investigate data flow from `packageName` on line 120 in `categorizeNewApp()`.
+  - [x] Investigate data flow from `appInfo` to `llmCategorizer.categorize()` from `categorizeNewApp()` on line 133.
+  - [x] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/CategorizationManager.kt
+  - [x] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/stages/BuiltInCategorizer.kt
+  - [x] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/CategoryTabsController.kt
+  - [x] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/CategoryTabsManager.kt
+  - [x] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/FolderAutoSortService.kt
+  - [x] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/importer/SmartLauncherImporter.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/learning/UserCorrectionLearner.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/llm/BatchCalculator.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/llm/ClaudeProvider.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/llm/ConfidenceCalibrator.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/llm/GoogleAIProvider.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/llm/LLMLogger.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/llm/LLMProvider.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/llm/ModelConfig.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/llm/OpenAIProvider.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/llm/PerplexityProvider.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/llm/ProviderCircuitBreaker.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/categorization/stages/LLMCategorizer.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/AssistantIconView.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/GoogleQsbContainerView.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/LawnQsbLayout.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/QsbIconUtil.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/AppSearch.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Bing.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Brave.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/DuckDuckGo.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Ecosia.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Fennec.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Firefox.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/GitHub.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Google.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/GoogleGo.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Iceraven.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/IronFox.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Kagi.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/PixelSearch.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Presearch.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/QsbSearchProvider.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Sesame.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Startpage.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Wikipedia.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Yandex.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/qsb/providers/Youtube.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/AppDatabase.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/Converters.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/folder/FolderEntity.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/folder/model/FolderViewModel.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/folder/service/FolderDao.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/folder/service/FolderService.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/iconoverride/IconOverride.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/iconoverride/IconOverrideDao.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/iconoverride/IconOverrideRepository.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/wallpaper/Wallpaper.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/wallpaper/model/WallpaperViewModel.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/wallpaper/service/WallpaperDao.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/wallpaper/service/WallpaperService.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/apps/AppMetadataProvider.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/apps/AppInfo.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/tab/entities/CustomTab.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/tab/entities/AppTab.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/tab/TabDatabase.kt
+  - [ ] SAST Recon on /data/data/com.termux/files/home/AutoCat/lawnchair/src/app/lawnchair/data/tab/TabDao.kt
+- [ ] Conduct the final review of all findings as per your **Minimizing False Positives** operating principle and generate the final report.